Better search function for tags
Closed this issue · 22 comments
hzc363 commented
Currently, the search function for existing tags on Annotate page can only takes the first letter. There will soon be thousands of tags. It will be helpful to have a more powerful search function for existing tags.
iDrDex commented
Some kind of autocomplete text box. Match on tag and description tokens.
Suor commented
Not sure how you search tags on Annotate page. Did you mean looking up tags in Tag control page? I guess we can add quick inplace filter on that one.
To @ir4y: add a text filter on this page left of create button:
- initially focused
- all tags are shown when field is empty
- when anything is typed in remove all tags on a page not matching the query
- query should be matched against tag title, description, ontology and concept name, case insensitive
- when all tags with some starting letter disappear, letter also disappears
To everyone: you can really use browser in page search for now.
ir4y commented
The feature is done.
You can check how it is working at this page http://stargeo.org/tags/
iDrDex commented
Search tags looks good. We need to index tag descriptions too when returning results. Searching for 'dengue' should reveal the DF DHFand DSS tags too. We also need this inplace filter on the annotate page.
ir4y commented
Now you can search by tag description at http://stargeo.org/annotations/ and http://stargeo.org/annotations/ pages.
iDrDex commented
Need the search on the annote page too: http://stargeo.org/annotate/?series_id=2099. The drop down for tag should be replaced with inplace filter.
Suor commented
So replace select with text auto compete. We got it wrong twice :)
ir4y commented
This feature is done and deployed.
iDrDex commented
We need to have the search function on the annotate page. See: http://stargeo.org/annotate/?series_id=2099. The Tag dropdown (name="tag_id") needs to be replaced with the in-place search that exists at: http://stargeo.org/tags/
Suor commented
Dexter you should elaborate. There are no tags on annotate page besides that field, so there is nothing to filter inplace.
iDrDex commented
It's too difficult to select from the drop down as we currently have hundreds of tags and will soon have thousands. We need to have an inplace filter much like for airport codes (like tags in our instance) when booking airline flights online.
dex* by iPhone
… On Dec 19, 2016, at 5:33 PM, Alexander Schepanovski ***@***.***> wrote:
Dexter you should elaborate. There are no tags on annotate page besides that field, so there is nothing to filter inplace.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
Suor commented
But it's not a simple dropdown now, you can type in to filter it.
20 дек. 2016 г. 8:48 пользователь "idrdex" <notifications@github.com>
написал:
… It's too difficult to select from the drop down as we currently have
hundreds of tags and will soon have thousands. We need to have an inplace
filter much like for airport codes (like tags in our instance) when booking
airline flights online.
dex* by iPhone
> On Dec 19, 2016, at 5:33 PM, Alexander Schepanovski <
***@***.***> wrote:
>
> Dexter you should elaborate. There are no tags on annotate page besides
that field, so there is nothing to filter inplace.
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARVx-lntnavJRuKbeHA9C5FryV8YLwzks5rJzPogaJpZM4LG_lf>
.
ir4y commented
@iDrDex I think it's a browser cache problem. Could you clean it up?
@Suor we need to add http://whitenoise.evans.io/en/stable/ for assets managment to prevent browser cache based problems.
iDrDex commented
Browser cache indeed! Reload on safari has the inplace filter working nicely. :) Can we please add the description to the drop down as well as the as tag name. And we might as well color the tag (green/grey) to be consistent (Only the tag name should be colored. Not description). Nice work guys.
dex* by iPhone
… On Dec 19, 2016, at 6:48 PM, Ilya Beda ***@***.***> wrote:
@iDrDex I think it's a browser cache problem. Could you clean it up?
@Suor we need to add http://whitenoise.evans.io/en/stable/ for assets managment to prevent browser cache based problems.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Suor commented
There is no meaningful way to color tags in select because tags having
annotations are excluded from where.
20 дек. 2016 г. 11:23 ДП пользователь "idrdex" <notifications@github.com>
написал:
Browser cache indeed! Reload on safari has the inplace filter working
nicely. :) Can we please add the description to the drop down as well as
the as tag name. And we might as well color the tag (green/grey) to be
consistent (Only the tag name should be colored. Not description). Nice
work guys.
dex* by iPhone
On Dec 19, 2016, at 6:48 PM, Ilya Beda ***@***.***> wrote:
@iDrDex I think it's a browser cache problem. Could you clean it up?
@Suor we need to add http://whitenoise.evans.io/en/stable/ for assets
managment to prevent browser cache based problems.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARVx28cDfsppzPvUvdBHGSv1qmERHckks5rJ1g0gaJpZM4LG_lf>
.
iDrDex commented
Then they should all be grey. Point is keep all tags with a background color for consistency.
dex* by iPhone
… On Dec 19, 2016, at 8:34 PM, Alexander Schepanovski ***@***.***> wrote:
There is no meaningful way to color tags in select because tags having
annotations are excluded from where.
20 дек. 2016 г. 11:23 ДП пользователь "idrdex" ***@***.***>
написал:
Browser cache indeed! Reload on safari has the inplace filter working
nicely. :) Can we please add the description to the drop down as well as
the as tag name. And we might as well color the tag (green/grey) to be
consistent (Only the tag name should be colored. Not description). Nice
work guys.
dex* by iPhone
> On Dec 19, 2016, at 6:48 PM, Ilya Beda ***@***.***> wrote:
>
> @iDrDex I think it's a browser cache problem. Could you clean it up?
>
> @Suor we need to add http://whitenoise.evans.io/en/stable/ for assets
managment to prevent browser cache based problems.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARVx28cDfsppzPvUvdBHGSv1qmERHckks5rJ1g0gaJpZM4LG_lf>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Suor commented
That would be misleading, grey now means there is an unconfirmed
annotation. After this change it will sometimes mean nothing.
20 дек. 2016 г. 12:49 пользователь "idrdex" <notifications@github.com>
написал:
… Then they should all be grey. Point is keep all tags with a background
color for consistency.
dex* by iPhone
> On Dec 19, 2016, at 8:34 PM, Alexander Schepanovski <
***@***.***> wrote:
>
> There is no meaningful way to color tags in select because tags having
> annotations are excluded from where.
>
> 20 дек. 2016 г. 11:23 ДП пользователь "idrdex" ***@***.***
>
> написал:
>
> Browser cache indeed! Reload on safari has the inplace filter working
> nicely. :) Can we please add the description to the drop down as well as
> the as tag name. And we might as well color the tag (green/grey) to be
> consistent (Only the tag name should be colored. Not description). Nice
> work guys.
>
> dex* by iPhone
>
>
> > On Dec 19, 2016, at 6:48 PM, Ilya Beda ***@***.***>
wrote:
> >
> > @iDrDex I think it's a browser cache problem. Could you clean it up?
> >
> > @Suor we need to add http://whitenoise.evans.io/en/stable/ for assets
> managment to prevent browser cache based problems.
> >
> > —
> > You are receiving this because you were mentioned.
>
> > Reply to this email directly, view it on GitHub, or mute the thread.
> >
>
> —
> You are receiving this because you were mentioned.
>
> Reply to this email directly, view it on GitHub
> <#57 (comment)
>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AARVx28cDfsppzPvUvdBHGSv1qmERHckks5rJ1g0gaJpZM4LG_lf>
> .
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARVx9pPcXifwZu_l_rxVOwjusewMC9pks5rJ2xagaJpZM4LG_lf>
.
iDrDex commented
If it's a brand new tag, then it's consistent and it must be grey as no validation exists. As in the user is adding a grey tag to our database, no? If they never hit save then no big deal. Once they hit save, the series gets updated with the grey tag as was presented to the user. I don't see an inconsistency. The only inconsistency I see is if we sometimes color tags on series and other times don't.
dex* by iPhone
… On Dec 19, 2016, at 9:52 PM, Alexander Schepanovski ***@***.***> wrote:
That would be misleading, grey now means there is an unconfirmed
annotation. After this change it will sometimes mean nothing.
20 дек. 2016 г. 12:49 пользователь "idrdex" ***@***.***>
написал:
> Then they should all be grey. Point is keep all tags with a background
> color for consistency.
>
> dex* by iPhone
>
> > On Dec 19, 2016, at 8:34 PM, Alexander Schepanovski <
> ***@***.***> wrote:
> >
> > There is no meaningful way to color tags in select because tags having
> > annotations are excluded from where.
> >
> > 20 дек. 2016 г. 11:23 ДП пользователь "idrdex" ***@***.***
> >
> > написал:
> >
> > Browser cache indeed! Reload on safari has the inplace filter working
> > nicely. :) Can we please add the description to the drop down as well as
> > the as tag name. And we might as well color the tag (green/grey) to be
> > consistent (Only the tag name should be colored. Not description). Nice
> > work guys.
> >
> > dex* by iPhone
> >
> >
> > > On Dec 19, 2016, at 6:48 PM, Ilya Beda ***@***.***>
> wrote:
> > >
> > > @iDrDex I think it's a browser cache problem. Could you clean it up?
> > >
> > > @Suor we need to add http://whitenoise.evans.io/en/stable/ for assets
> > managment to prevent browser cache based problems.
> > >
> > > —
> > > You are receiving this because you were mentioned.
> >
> > > Reply to this email directly, view it on GitHub, or mute the thread.
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> >
> > Reply to this email directly, view it on GitHub
> > <#57 (comment)
> >,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AARVx28cDfsppzPvUvdBHGSv1qmERHckks5rJ1g0gaJpZM4LG_lf>
> > .
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub, or mute the thread.
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#57 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AARVx9pPcXifwZu_l_rxVOwjusewMC9pks5rJ2xagaJpZM4LG_lf>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Suor commented
Some tags are not tied to series, because there is no annotation yet. Tags
in tag control are not even in context of any particular serie, so no color
meaning for them at all.
So, now: grey - annotation exists for serie, green - annotation validated,
no color - untied tag. Do you understand it other way around?
20 дек. 2016 г. 1:14 ПП пользователь "idrdex" <notifications@github.com>
написал:
If it's a brand new tag, then it's consistent and it must be grey as no
validation exists. As in the user is adding a grey tag to our database, no?
If they never hit save then no big deal. Once they hit save, the series
gets updated with the grey tag as was presented to the user. I don't see an
inconsistency. The only inconsistency I see is if we sometimes color tags
on series and other times don't.
dex* by iPhone
On Dec 19, 2016, at 9:52 PM, Alexander Schepanovski <
notifications@github.com> wrote:
That would be misleading, grey now means there is an unconfirmed
annotation. After this change it will sometimes mean nothing.
20 дек. 2016 г. 12:49 пользователь "idrdex" ***@***.***>
написал:
> Then they should all be grey. Point is keep all tags with a background
> color for consistency.
>
> dex* by iPhone
>
> > On Dec 19, 2016, at 8:34 PM, Alexander Schepanovski <
> ***@***.***> wrote:
> >
> > There is no meaningful way to color tags in select because tags having
> > annotations are excluded from where.
> >
> > 20 дек. 2016 г. 11:23 ДП пользователь "idrdex" <
notifications@github.com
> >
> > написал:
> >
> > Browser cache indeed! Reload on safari has the inplace filter working
> > nicely. :) Can we please add the description to the drop down as well
as
> > the as tag name. And we might as well color the tag (green/grey) to be
> > consistent (Only the tag name should be colored. Not description).
Nice
> > work guys.
> >
> > dex* by iPhone
> >
> >
> > > On Dec 19, 2016, at 6:48 PM, Ilya Beda ***@***.***>
> wrote:
> > >
> > > @iDrDex I think it's a browser cache problem. Could you clean it up?
> > >
> > > @Suor we need to add http://whitenoise.evans.io/en/stable/ for
assets
> > managment to prevent browser cache based problems.
> > >
> > > —
> > > You are receiving this because you were mentioned.
> >
> > > Reply to this email directly, view it on GitHub, or mute the thread.
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> >
> > Reply to this email directly, view it on GitHub
> > <#57
issuecomment-268151177
> >,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AARVx28cDfsppzPvUvdBHGSv1qmERHckks5rJ1g0gaJpZM4LG_lf>
> > .
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub, or mute the thread.
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#57 (comment)
,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AARVx9pPcXifwZu_l_
rxVOwjusewMC9pks5rJ2xagaJpZM4LG_lf>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARVx1gSyHQ6kRqkfcontVI3O8Qu2oDKks5rJ2_1gaJpZM4LG_lf>
.
iDrDex commented
I agree http://stargeo.org/tags/ is inconsistent with colors. I'd turn that page into a tag dashboard of types. Number of series tagged. Number of users that tagged them. Average kappa. Etc. I guess for that no background color.
I agree the colored tags should only apply to series. And while we are at it make a red color for invalid tags (kappa < 1).
dex* by iPhone
… On Dec 19, 2016, at 10:40 PM, Alexander Schepanovski ***@***.***> wrote:
Some tags are not tied to series, because there is no annotation yet. Tags
in tag control are not even in context of any particular serie, so no color
meaning for them at all.
So, now: grey - annotation exists for serie, green - annotation validated,
no color - untied tag. Do you understand it other way around?
20 дек. 2016 г. 1:14 ПП пользователь "idrdex" ***@***.***>
написал:
If it's a brand new tag, then it's consistent and it must be grey as no
validation exists. As in the user is adding a grey tag to our database, no?
If they never hit save then no big deal. Once they hit save, the series
gets updated with the grey tag as was presented to the user. I don't see an
inconsistency. The only inconsistency I see is if we sometimes color tags
on series and other times don't.
dex* by iPhone
> On Dec 19, 2016, at 9:52 PM, Alexander Schepanovski <
***@***.***> wrote:
>
> That would be misleading, grey now means there is an unconfirmed
> annotation. After this change it will sometimes mean nothing.
>
> 20 дек. 2016 г. 12:49 пользователь "idrdex" ***@***.***>
> написал:
>
> > Then they should all be grey. Point is keep all tags with a background
> > color for consistency.
> >
> > dex* by iPhone
> >
> > > On Dec 19, 2016, at 8:34 PM, Alexander Schepanovski <
> > ***@***.***> wrote:
> > >
> > > There is no meaningful way to color tags in select because tags having
> > > annotations are excluded from where.
> > >
> > > 20 дек. 2016 г. 11:23 ДП пользователь "idrdex" <
***@***.***
> > >
> > > написал:
> > >
> > > Browser cache indeed! Reload on safari has the inplace filter working
> > > nicely. :) Can we please add the description to the drop down as well
as
> > > the as tag name. And we might as well color the tag (green/grey) to be
> > > consistent (Only the tag name should be colored. Not description).
Nice
> > > work guys.
> > >
> > > dex* by iPhone
> > >
> > >
> > > > On Dec 19, 2016, at 6:48 PM, Ilya Beda ***@***.***>
> > wrote:
> > > >
> > > > @iDrDex I think it's a browser cache problem. Could you clean it up?
> > > >
> > > > @Suor we need to add http://whitenoise.evans.io/en/stable/ for
assets
> > > managment to prevent browser cache based problems.
> > > >
> > > > —
> > > > You are receiving this because you were mentioned.
> > >
> > > > Reply to this email directly, view it on GitHub, or mute the thread.
> > > >
> > >
> > > —
> > > You are receiving this because you were mentioned.
> > >
> > > Reply to this email directly, view it on GitHub
> > > <#57
issuecomment-268151177
> > >,
> > > or mute the thread
> > > <https://github.com/notifications/unsubscribe-auth/
> > AARVx28cDfsppzPvUvdBHGSv1qmERHckks5rJ1g0gaJpZM4LG_lf>
> > > .
> > > —
> > > You are receiving this because you were mentioned.
> > > Reply to this email directly, view it on GitHub, or mute the thread.
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <#57 (comment)
>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/AARVx9pPcXifwZu_l_
rxVOwjusewMC9pks5rJ2xagaJpZM4LG_lf>
> > .
> >
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARVx1gSyHQ6kRqkfcontVI3O8Qu2oDKks5rJ2_1gaJpZM4LG_lf>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
ir4y commented
I think we don't need to change the color of select options.
At annotate page we are selecting a tag and it's a simple form element.
Only after serie will be annotated with tag, the tag should get color.
I have created a separated task to track tag page enhancement.