ianyepan/vscode-dark-plus-emacs-theme

Inconsistent header-line border color in lsp-mode breadcrumb

Closed this issue · 5 comments

Issue:

In the header line, the border color for the words common, loggers, loggers.go and the character > is different from the color of the rest of the border (see top-left of screenshot below). FYI, the header is the breadcrumb from lsp-mode.

Question: Is there a way to have a consistent border color across the header line?

image

Same situation occurs for the built-in manual:

image

Expected behavior / look-and-feel:

Something that looks more natural might be like the Zenburn theme:

image

Update: I found this commit 1e694e1, will it help to solve the above issue?

Update: I found this commit 1e694e1, will it help to solve the above issue?

I've made header-line look exactly like the mode-line, without inheriting it. This simultaneously fixes #23 and #10.

Wait, mode-line's background is way too much. I'll make it dark grey...

Looks good to me now

image

@ianpan870102 Thanks for the amazingly fast fix! (And also the theme in the first place! 💯 )