icaropires/vandor-rename

Write some tests

Closed this issue · 6 comments

icaropires commented

Would be cool to have some tests for validating the existing functions.

suv27 commented
  • I can help write python scripts, would it be only for vandor-rename.py since is the only python file in the repo?
  • How would you list it structure?
  • I am planning to create a tests/ folder and write a <funciton>_test.py file for each function found in the vandor-rename.py
icaropires commented 
* I can help write python scripts, would it be only for `vandor-rename.py` since is the only python file in the repo?

* How would you list it structure?

* I am planning to create a `tests/` folder and write a `<funciton>_test.py` file for each function found in the `vandor-rename.py`

Hi! Thanks for the interest in contributing 😃 !
Yes, just for the vandor-rename.py.

About the structure, you can create just one file under tests/ and write all unit tests at this unique file. The intention is to keep one test file for one source file 😉 .

  • 👍1
suv27 commented

When I get all the tests ready I will open a PR, just make sure this issue is assigned to me.
I need to understand the code better

  • 👍1
suv27 commented

Wrote some tests, when I get more chance I will write more. #20

suv27 commented

I believe you should make issues base on testing each specific function.

icaropires commented

I believe you should make issues base on testing each specific function.

No, I don't think this is a good idea. Only if there were super complex functions. But this is not the case.