reserved identifier violation
elfring opened this issue · 4 comments
elfring commented
I would like to point out that identifiers like “_API_H_” and “_DISPLAY_H_” do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
idea4good commented
Thanks, will fix it up soon
elfring commented
I would prefer to keep this issue open until it will be fixed finally.
idea4good commented
Sure, It looks the issue has been fixed, would you please take a check?
Thanks
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
…________________________________
From: Markus Elfring <notifications@github.com>
Sent: Saturday, February 2, 2019 7:43:56 PM
To: idea4good/GuiLite
Cc: idea4good; State change
Subject: Re: [idea4good/GuiLite] reserved identifier violation (#22)
I would prefer to keep this issue open<https://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier#answer-228797> until it will be fixed finally.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#22 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AXEfPceyWd9FGB5tTH9n8X4KTlXfZuKxks5vJXn8gaJpZM4aexwD>.
elfring commented