ignism/nucleus-dark-ui

Font color for focused line in find-and-replace

Closed this issue · 3 comments

In the find and replace dialog, when input lines are focused, the background color changes. It looks like the selector that sets the font color in this case doesn't apply if the "Use Regex" option is selected.

With no options, there is good contrast between the background and font color in the focused line (where I've typed "high contrast").

high-contrast

Here is the relevant markup for the screenshot above:

<span class="text plain null-grammar">high contrast</span>

When you select the "Use Regex" option, the font color for the focused line changes. This results in much lower contrast between the background and font color.

low-contrast

And here is the relevant markup for the screenshot above:

<span class="source js regexp">low contrast</span>

I see this CSS applied when I do not have the "Use Regex" option selected.

atom-text-editor[mini].is-focused .text,
atom-text-editor[mini].is-focused::shadow .text {
  color #1d1f21;
}

I assume it would be enough to add selectors for the source class as well - though I don't know if this will consistently do the right thing.

The changes in this branch fix the issue for me: master...tschaub:search-text

Would you accept a pull request or suggest another way of solving this?

I will look into this, I noticed the font also changes, but doesnt change back if you turn regexp off.

should be fixed in patch 0.8.3, let me know if this is ok for you.

Looks good to me. Thanks for the great theme @ignism.