MC unit handling on interface to XCSoar

Question

MC unit handling on interface to XCSoar

Closed this issue 3 years ago · 10 comments

Describe the bug
XCV and connected XCS exchange MC values. From XCS to XCV does not handle units correctly when set to something else than m/s on XCV side.
E.g. XCS sends MC 1 m/s XCV receives 200feet/min, or 1,9knots when set to knots as unit.

To Reproduce
XCS on e.g. Laptop connected to S2. Setup XCV interface on XCS and change MC manually.

Expected behavior
Show the adjusted same value, or proper converted value on XCV side.

Desktop (please complete the following information):
Linux laptop, XCS compiled from head, XCV compiled from head.

Answer 1 · 2021-10-18T19:22:52.000Z

Fix keeping standard format in hPa and inHg only for display comes here:
769eb98

Answer 2 · 2021-10-20T11:08:50.000Z

Please reopen. The fix is not related to the issue and does not fix it.

Answer 3 · 2021-10-20T11:28:26.000Z

For testing:
508311d

Answer 4 · 2021-10-22T11:33:41.000Z

In my gadgets i don't see issue with above change , can this be closed ?

Answer 5 · 2021-10-22T12:11:20.000Z

Will double check. one moment.

Answer 6 · 2021-10-22T12:23:24.000Z

Ok, now the setting seems to be right, but just the display indicates m/s always. Will fix too.

Answer 7 · 2021-10-22T13:02:47.000Z

Contributed with PR #82 a bit to it but this is not yet completely fixed. Choosing r.g. 100ft/min as vario unit still shows on the config setting where you change the MC value a m/s figure, but x 100ft/min right behind it. This need to be a fit to the figure as well.

Answer 8 · 2021-10-22T15:26:57.000Z

Sure the MC setup screen needed the unit from vario for Units:: as well. Will crosscheck this also.

Answer 9 · 2021-10-25T19:51:27.000Z

Apparently the new blackboard approach fixes this.

Answer 10 · 2021-10-26T18:02:04.000Z

Yip, please close. #86 was dedicated to this issue. The specific class Vario can display vertical speeds in configured units.