Security Group Validity Check

Question

Security Group Validity Check

edwinquaihoi opened this issue 5 years ago · 7 comments

Hi I am facing an issue when using the replace-environment goal ... somewhere along the way, line 133 in the AbstractBeanstalkMojo class is being called to regex check the names of security groups which fails for my environment because our security group ids (sg-0f8c950bc7329a653,sg-06d4615187690e062) don't match the regex.

Do we need this validation line in the code?

Validate.isTrue(securityGroup.matches("^sg-\\p{XDigit}{8}(,sg-\\p{XDigit}{8})*$"), "Invalid Security Group Spec: " + securityGroup);

Answer 1 · 2019-09-24T04:18:59.000Z

I knew that sometimes my code would bite me! Could do a PR? From a first glance, replacing "{8}" with "{8,16}" twice sounds like a reasonable fix (although not perfect)

…

On Mon, Sep 23, 2019 at 11:07 PM edwinquaihoi ***@***.***> wrote: Hi I am facing a issue when using the replace-environment goal ... somewhere along the way, line 133 in the AbstractBeanstalkMojo class is being called to regex check the names of security groups which fails for my environment because our security group ids (sg-0f8c950bc7329a653,sg-06d4615187690e062) don't match the regex. Do we need this validation line in the code? Validate.isTrue(securityGroup.matches("^sg-\\p{XDigit}{8}(,sg-\\p{XDigit}{8})*$"), "Invalid Security Group Spec: " + securityGroup); — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#125?email_source=notifications&email_token=AAB5ZNJSLEYIEYZCKQ2YCSTQLGG6HA5CNFSM4IZ2M7P2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HNGLZZA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB5ZNLLXNNLQ4FX4DJFEK3QLGG6HANCNFSM4IZ2M7PQ> .

Answer 2 · 2019-09-24T04:23:18.000Z

oh nvm. publishing a new release/fix

Answer 3 · 2019-09-24T04:26:40.000Z

Thanks @aldrinleal , are you going to remove the code or patch the regex? Our security groups have more than 16 XDigits.

Answer 4 · 2019-09-24T04:30:09.000Z

Nice catch. I was under the impression it was 16, but amazon said its now 17 instead

Answer 5 · 2019-09-24T04:34:50.000Z

This should do the trick

(and I've had to bump some plugins in the way for the build to proceed - I believe its fixed, but we never know...)

Answer 6 · 2019-09-24T04:42:57.000Z

Thanks @aldrinleal really appreciate the quick turnaround. When do you anticipate it being in the MVN Repo?

Answer 7 · 2019-09-24T06:01:43.000Z

It took a while, had to update plugins and fix some javadocs, and my main ISP had a failure so I did that on tethering, but I've managed to release it. \o/

Should be in central in a couple of hours