insightsengineering/scda.2022

include updated cache data [part 1]

Closed this issue · 7 comments

shajoezhu commented

Motivation

Rencent changes updated random cdisc data

  • ADSL: ETHNIC, DTHADY
  • ADCM: CMINDC, CMDOSE, CMTRT, CMDOSU, CMROUTE, CMDOSFRQ
  • ADHM: MHDISTAT
  • ADVS: ANRLO, ANRHI
  • ADLB: ANRLO, ANRHI
  • ADAE: AERELNST
  • ADPC: NRELTM2

TODO

Definition of done

Updated data

yli110-stat697 commented

Hi @shajoezhu I see there are two pending PRs for this package failing automation. Will these be fixed?

shajoezhu commented

Hi @yli110-stat697 , coredev team will help us to initiate this repo for now. Thanks!

codesformochi commented

@shajoezhu - i tried updating the data but it's still not identifying the latest ADSL (i.e. no ADSL.ETHNIC). But when i look in my random.cdisc.data i see ADSL.ETHNIC.

is there something I'm missing?

shajoezhu commented

Hi @codesformochi , at line https://github.com/insightsengineering/scda.2022/blob/main/data_raw/rcd.R#L10, you can see, it is currently pointing to this commit insightsengineering/random.cdisc.data@7f22003,

please update, and point it to "0cc1d7dd8a79db29fff81f68630181ffe1836e83"

It will then resolve the problem :)

  • 👍1
codesformochi commented

thanks @shajoezhu ! i thought that might be the case but the commit # was much shorter in gh so i thought maybe not xP didn't know gh shortened commit. i'll give it a try and let you know.

pawelru commented

new snapshot created which is used by tern