BCT can't open Eagle Stream's bsf
memristor2 opened this issue · 8 comments
Hello
I am trying to use the bct tool to patch the fsp.fd file. Unfortunately BCT isn't able to open the associated BSF file.
.
Please try using the Config Editor tool -
Config Editor tool for FSP configuration
Link: https://github.com/tianocore/edk2/tree/master/IntelFsp2Pkg/Tools/ConfigEditor
@swong23 Thank you.
I don't know if you have checked this yourself or not. But unfortunately the config Editor Tool doesn't load the parameters of Eagle Streams BSF file either
It looks to me like the published file is incomplete / broken. It's many fewer lines than other published .bsf files (only 144 lines compared to many thousands). Also, it starts with a StructDef but no associated EndStruct.
usually, you can directly configure the UPD parameters directly from BIOS like coreboot or Slim bootloader, so BCT tool or config editor tool comes secondary. it is because the tool only changes the 'default' settings of FSP, if BIOS reference code like coreboot overwrites the UPD settings, then the default setting will be ignored.
Fixed in #100
The merge/pull request is still open, and I think it’s common practice to leave the corresponding issue open until the merge/pull request is accepted and merged/submitted. If you add a line
Resolves: #99
to the commit message of the commit fixing the issue, then GitHub is going to close the issue automatically, when the merge/pull request is merged/submitted.
@paulmenzel I simply did this to close it since it was not an issue for me anymore. But you're right Ill reopen it and let the contributers close it
Fixed in e07f875