Custom margins per CardController

Question

Custom margins per CardController

jmjordan opened this issue 5 years ago · 9 comments

Is your feature request related to a problem? Please describe.
Yes, cards within a CardsViewController must all have the same margin.

Describe the solution you'd like
I'd like a way to specify a custom margin for an individual card with a CardsViewController. The main reason is to specify 0 margin for things like transparent cards that need to be the full width of the view.

Describe alternatives you've considered
Instead of allowing for any margin, the solution could just be for cards that need to be the full width of the screen.

Additional context
I have completed the feature on my fork and am ready to submit a PR if this idea is approved.

jmjordan commented 5 years ago

PR: #208

Answer 1 · 2019-12-04T02:37:36.000Z

This is awesome, @jmjordan. Please open a PR so that we can take a look. Looking forward to reviewing it!

Answer 2 · 2019-12-04T02:44:42.000Z

@jmjordan this feature is already present make use of below parameter to set custom margins, by default they are set to default cardPart theme margins. // allow customization of cardCellMargins for an individual CardsViewController; still default to theme public var cardCellMargins : UIEdgeInsets = CardParts.theme.cardCellMargins Thanks, Badarinath

…

On Wed, Dec 4, 2019 at 8:07 AM Chase ***@***.***> wrote: This is awesome, @jmjordan <https://github.com/jmjordan>. Please open a PR so that we can take a look. Looking forward to reviewing it! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#207?email_source=notifications&email_token=AALJECY2AXGGGNKMMNRA2RLQW4JXDA5CNFSM4JU7HPM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3QR6Q#issuecomment-561449210>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALJEC7SJKAXCQ2QDDFWGNDQW4JXDANCNFSM4JU7HPMQ> .

Answer 3 · 2019-12-04T02:59:15.000Z

This is awesome, @jmjordan. Please open a PR so that we can take a look. Looking forward to reviewing it!

@croossin Will do!

_{Sent with GitHawk}

Answer 4 · 2019-12-04T03:00:25.000Z

@jmjordan this feature is already present make use of below parameter to ...

@badrinathvm I believe that feature only allows having a custom margin for all cards in a CardsViewController. My proposed feature would allow for custom margins on individual cards.

_{Sent with GitHawk}

Answer 5 · 2019-12-04T03:03:52.000Z

Yes the parameter which I mentioned does for all the cards not for individual ones. Would be available to see your PR and validate. Thanks, Badarinath

…

On Wed, Dec 4, 2019 at 8:30 AM jmjordan ***@***.***> wrote: @jmjordan <https://github.com/jmjordan> this feature is already present make use of below parameter to ... @badrinathvm <https://github.com/badrinathvm> I believe that feature only allows having a custom margin for all cards in a CardsViewController. My proposed feature would allow for custom margins on individual cards. Sent with GitHawk <http://githawk.com> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#207?email_source=notifications&email_token=AALJEC6EBGUBSHSKGBWLD3LQW4MM3A5CNFSM4JU7HPM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3RYAI#issuecomment-561454081>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALJEC24BN3ENC7U4OTVDW3QW4MM3ANCNFSM4JU7HPMQ> .

Answer 6 · 2019-12-04T03:04:48.000Z

@badrinathvm As Jordan mentioned, we only have the ability to set for all cards, not individual cards. @jmjordan Please open a PR 😄 thanks.

Answer 7 · 2019-12-04T03:08:11.000Z

Yes @croossin , I mentioned Jordan to create a PR to validate.

…

On Wed, Dec 4, 2019 at 8:34 AM Chase ***@***.***> wrote: @badrinathvm <https://github.com/badrinathvm> As Jordan mentioned, we only have the ability to set for all cards, not individual cards. @jmjordan <https://github.com/jmjordan> Please open a PR 😄 thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#207?email_source=notifications&email_token=AALJEC4G6QUB4LSEGCL3IALQW4M5FA5CNFSM4JU7HPM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3SBAI#issuecomment-561455233>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALJEC4ENSWXGPLF7OQRCHTQW4M5FANCNFSM4JU7HPMQ> .

Answer 8 · 2019-12-06T16:02:32.000Z

Completed in PR #208 and Version 2.22.0