ionic-team/starters

Unsupported Node v14.x.x LTS upgrade deprecated warnings in Ionic 5.x starter app

edocbuhtig opened this issue ยท 6 comments

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:
After updating the lastest Nodejs stable verision v14.x and running npm install throws deprecated and unsupported warnings as below:

npm WARN notsup Unsupported engine for watchpack-chokidar2@2.0.0: wanted: {"node":"<8.10.0"} (current: {"node":"14.15.0","npm":"6.14.8"})
npm WARN notsup Not compatible with your version of node/npm: watchpack-chokidar2@2.0.0
npm WARN codelyzer@5.2.2 requires a peer of @angular/compiler@>=2.3.1 <10.0.0 || >9.0.0-beta <10.0.0 || >9.1.0-beta <10.0.0 || >9.2.0-beta <10.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN codelyzer@5.2.2 requires a peer of @angular/core@>=2.3.1 <10.0.0 || >9.0.0-beta <10.0.0 || >9.1.0-beta <10.0.0 || >9.2.0-beta <10.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN karma-jasmine-html-reporter@1.5.4 requires a peer of karma@>=0.9 but none is installed. You must install peer dependencies yourself.
npm WARN karma-jasmine@3.3.1 requires a peer of karma@* but none is installed. You must install peer dependencies yourself.

Expected behavior:
The Ionic 5 starter apps should support node v14.x

Steps to reproduce:

  • Update your local workstation nodejs to v14.x.x stable
  • Create a new blank starter ionic angular app

Ionic info:

Ionic:

   Ionic CLI                     : 6.12.1 
   Ionic Framework               : @ionic/angular 5.4.1
   @angular-devkit/build-angular : 0.1002.0
   @angular-devkit/schematics    : 10.0.8
   @angular/cli                  : 10.0.8
   @ionic/angular-toolkit        : 2.3.3

Someone please look into this one, its critical and kind of blocker for node v14+ upgrade

@mhartington - All starter apps need a upgrade for node v14+ LTA

I just updated to node14/LTS and I'm not able to replicate this issue.

If you just updated your workspace, you might need to also clear your current node_modules and do a fresh install.
If you can provide a sample project that has the issue, then we can look into it further, but right now everything looks pretty good on our end.

@mhartington Thanks for the quick turnaround, I still see below if i delete my node_modules

npm WARN deprecated tslint@6.1.3: TSLint has been deprecated in favor of ESLint. Please see https://github.com/palantir/tslint/issues/4534 for more information.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated

Are they going to stay as "deprecated warning" would it be nice to have them removed / replaced with compatible versions of NPM libraries?

Is this for this repo itself? Or the starter projects you create/download?

@mhartington - Above applies to all new "starter" combinations like blank side menu etc for:

ionic start command

ionic start test blank

Pick a framework! ๐Ÿ˜

Please select the JavaScript framework to use for your new app. To bypass this
prompt next time, supply a value for the --type option.

? Framework: Angular
โœ” Preparing directory ./test in 1.52ms
โœ” Downloading and extracting blank starter in 456.49ms
? Integrate your new app with Capacitor to target native iOS and Android? No

Installing dependencies may take several minutes.

  โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€

         Ionic Advisory, tailored solutions and expert services by Ionic

                             Go to market faster ๐Ÿ†
                    Real-time troubleshooting and guidance ๐Ÿ’
        Custom training, best practices, code and architecture reviews ๐Ÿ”Ž
      Customized strategies for every phase of the development lifecycle ๐Ÿ”ฎ

                        ๐Ÿ‘‰  https://ion.link/advisory  ๐Ÿ‘ˆ

  โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€


> npm i
npm WARN deprecated tslint@6.1.3: TSLint has been deprecated in favor of ESLint. Please see https://github.com/palantir/tslint/issues/4534 for more information.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated

Ionic CLI version
6.12.1

Nodejs
v14.15.0

NPM
6.14.8

MAC OS
Catalina v10.15.7

so there's 2 different messages being provided. The one at the beginning I am not able to replicate.
The second set are just warnings, not errors. Angular (and some deps of angular) are using out of date deps, which would be causing those warnings. But the do not cause issues with projects. Think of these as more of suggestions.

Either way, these are not issues with the starters, just rather warnings from upstream.
Going to close this.