using namespace std; in the public header
Closed this issue · 3 comments
GoogleCodeExporter commented
Hello.
using namespace std; pollutes global namespace. It is a good practice not to do
this in the header files. I've cleaned the your header from this evil :)
https://www.dropbox.com/s/t9ofl7w51y3qzn5/polypartition.h
It will be great if you can commit this.
Also see:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
for more details and tips
Also I made some minor refactorings in cpp file:
https://www.dropbox.com/s/61xp6cb79hqzpx9/polypartition.cpp
Original issue reported on code.google.com by geotav...@gmail.com
on 30 Jul 2013 at 4:17
GoogleCodeExporter commented
also please confirm that you've got the files from dropbox so I can delete them
Original comment by geotav...@gmail.com
on 30 Jul 2013 at 4:18
GoogleCodeExporter commented
Thanks, I received the files. I'll review the changes next week and, assuming
everything is OK, add them to the repository.
Original comment by ivan.fra...@gmail.com
on 30 Jul 2013 at 8:49
- Added labels: Type-Enhancement
- Removed labels: Type-Defect
GoogleCodeExporter commented
The header file was fixed a while ago.
Original comment by ivan.fra...@gmail.com
on 14 Sep 2014 at 10:53
- Changed state: Fixed