F-Droid can't build
licaon-kter opened this issue · 15 comments
licaon-kter commented
as com.google.android.gms:play-services-location is not FOSS
ref: https://monitor.f-droid.org/builds/log/org.avmedia.gshockGoogleSync/133#site-footer
ref: bbc54e6#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9R110
/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/5d6bcd3b90c04c2574059ea0d448e74dcd77cb11
izivkov commented
Ok, I'll remove it and update.
…On Mon, Jul 22, 2024, 1:01 PM Licaon_Kter ***@***.***> wrote:
as com.google.android.gms:play-services-location is not FOSS
ref:
https://monitor.f-droid.org/builds/log/org.avmedia.gshockGoogleSync/133#site-footer
ref: bbc54e6
#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9R110
<bbc54e6#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9R110>
—
Reply to this email directly, view it on GitHub
<#87>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7M37XFKJDSCVHWVTQWWYTZNU3GTAVCNFSM6AAAAABLIW3EKWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZDGMZUGA2DENQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
licaon-kter commented
another thing, can you clean up translations before tagging or we should inject ExtraTranslation or something else? https://gitlab.com/fdroid/fdroiddata/-/jobs/7407886941#L618
izivkov commented
I'll fix it for the next tag.
…On Tue, Jul 23, 2024, 10:30 AM Licaon_Kter ***@***.***> wrote:
another thing, can you clean up translations before tagging or we should
inject ExtraTranslation or something else?
https://gitlab.com/fdroid/fdroiddata/-/jobs/7407886941#L618
—
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7M37QUALZLT4W6FVRI5FLZNZSJTAVCNFSM6AAAAABLIW3EKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVGQYTKNBZHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
licaon-kter commented
still a thing :( https://gitlab.com/fdroid/fdroiddata/-/jobs/7507904706
izivkov commented
Hmm, not sure what that is. Are you sure this is not something on your end?
Can you try again? If not solved, I'll tag again.
Thanks
…On Mon, Aug 5, 2024, 11:11 AM Licaon_Kter ***@***.***> wrote:
still a thing :( https://gitlab.com/fdroid/fdroiddata/-/jobs/7507904706
—
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7M37SF3762OVHUXGUEPL3ZP6IY3AVCNFSM6AAAAABLIW3EKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZGMYTAMZTGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
licaon-kter commented
Not sure I follow, the string is here: https://github.com/izivkov/CasioGShockSmartSync/blob/v13.7/app/src/main/res/values-zh-rCN/strings.xml#L27-L31 in your code base
you added it in 9a7acee#diff-d9c30b0c0a46ff73de30b4ec09e9219f1edad9a9ce584661d8170e5545d6aa50R27
izivkov commented
How can I find out what is wrong? The link just shows a 505 page. I think I
corrected the issue with the extra string in one of the string.xml, and it
appears correct in the IDE. Cal I run the f-droid build chain locally so I
can see the error before tagging? I'm not a devop.
…On Tue, Aug 6, 2024, 10:56 AM Licaon_Kter ***@***.***> wrote:
and https://gitlab.com/fdroid/fdroiddata/-/jobs/7517764289#L689
—
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7M37XFJJ2I6FKI52JWGITZQDPZJAVCNFSM6AAAAABLIW3EKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZRGQ4TQNRWGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
licaon-kter commented
The link just shows a 505 page
link works fine for me
error is now:
> Task :app:lintVitalRelease FAILED
/home/vagrant/build/org.avmedia.gshockGoogleSync/app/src/main/java/org/avmedia/gShockPhoneSync/services/KeepAliveManager.kt:40: Error: Missing PendingIntent mutability flag [UnspecifiedImmutableFlag]
val pendingIntent = PendingIntent.getActivity(this, 0, notificationIntent, 0)
~
Explanation for issues of type "UnspecifiedImmutableFlag":
Apps targeting Android 12 and higher must specify either FLAG_IMMUTABLE or
FLAG_MUTABLE when constructing a PendingIntent.
FLAG_IMMUTABLE is available since target SDK 23, and is almost always the
best choice. See
https://developer.android.com/guide/components/intents-filters#CreateImmuta
blePendingIntents for a list of common exceptions to this rule.
https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability
https://goo.gle/UnspecifiedImmutableFlag
1 errors, 0 warnings
izivkov commented
OK, thanks for providing this message. This is what I got:
[image: image.png]
Regards
…On Tue, Aug 6, 2024 at 11:31 AM Licaon_Kter ***@***.***> wrote:
The link just shows a 505 page
link works fine for me
error is now:
> Task :app:lintVitalRelease FAILED
/home/vagrant/build/org.avmedia.gshockGoogleSync/app/src/main/java/org/avmedia/gShockPhoneSync/services/KeepAliveManager.kt:40: Error: Missing PendingIntent mutability flag [UnspecifiedImmutableFlag]
val pendingIntent = PendingIntent.getActivity(this, 0, notificationIntent, 0)
~
Explanation for issues of type "UnspecifiedImmutableFlag":
Apps targeting Android 12 and higher must specify either FLAG_IMMUTABLE or
FLAG_MUTABLE when constructing a PendingIntent.
FLAG_IMMUTABLE is available since target SDK 23, and is almost always the
best choice. See
https://developer.android.com/guide/components/intents-filters#CreateImmuta
blePendingIntents for a list of common exceptions to this rule.
https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability
https://goo.gle/UnspecifiedImmutableFlag
1 errors, 0 warnings
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:lintVitalRelease'.
> Lint found fatal errors while assembling a release target.
Fix the issues identified by lint, or create a baseline to see only new errors.
To create a baseline, run `gradlew updateLintBaseline` after adding the following to the module's build.gradle file:
android {
lint {
baseline = file("lint-baseline.xml")
}
}
For more details, see https://developer.android.com/studio/write/lint#snapshot
/home/vagrant/build/org.avmedia.gshockGoogleSync/app/src/main/java/org/avmedia/gShockPhoneSync/services/KeepAliveManager.kt:40: Error: Missing PendingIntent mutability flag [UnspecifiedImmutableFlag]
val pendingIntent = PendingIntent.getActivity(this, 0, notificationIntent, 0)
~
Explanation for issues of type "UnspecifiedImmutableFlag":
Apps targeting Android 12 and higher must specify either FLAG_IMMUTABLE or
FLAG_MUTABLE when constructing a PendingIntent.
FLAG_IMMUTABLE is available since target SDK 23, and is almost always the
best choice. See
https://developer.android.com/guide/components/intents-filters#CreateImmuta
blePendingIntents for a list of common exceptions to this rule.
https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability
https://goo.gle/UnspecifiedImmutableFlag
1 errors, 0 warnings
—
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7M37SRDHFFFUF2OA5EQ73ZQDT57AVCNFSM6AAAAABLIW3EKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZRGU3TONBRHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
licaon-kter commented
these email replies you do have missing images 😄
izivkov commented
I am going to use a linter before tagging
licaon-kter commented
Ah, network glitches on Gitlab, yeah :)
izivkov commented
Running lint against the code, showed the error you reported. I fixed it and tagged again. Will run lint from now on. Thanks.
licaon-kter commented