jaakkos/winston-logstash

deprecated setting in recommended config

matanox opened this issue · 2 comments

matanox commented

+1 for open-sourcing this :)

There's a small something that maybe the TODO list already covers. Putting the recommended configuration into a file for logstash to run:

# from https://github.com/jaakkos/winston-logstash
input {
   # Sample input over TCP
   tcp { format => "json" charset => "UTF-8" port => 28777 type=>"sample" }
}
output {
   stdout { debug => true debug_format => "json"}
}

triggers logstash deprecation warnings, the first of which being:
You are using a deprecated config setting "format" set in tcp. Deprecated settings will continue to work, but are scheduled for removal from logstash in the future. You should use the newer 'codec' setting instead.

Would be nice updating to the new format, given this module requires specific logstash configuration.

jaakkos commented

Thanks :)
Yep, format is deprecated. http://logstash.net/docs/1.3.3/inputs/tcp
I'll update the sample config.

jupiter commented

Does the fact that the example config use a filter and not a codec indicate that codec doesn't work?