jameskermode/f90wrap

Python 3.11 support

jan-janssen opened this issue · 8 comments

Hi @jameskermode ,

As conda-forge is moving forward in adding support for Python 3.11 we noticed that f90wrap is not yet compatible. If you have a moment it would be great to add Python 3.11 support.
conda-forge/f90wrap-feedstock#32

Best,

Jan

Thanks for reporting. Yes, I'd noticed Python 3.11 failures in f90wrap's wheel-building CI so this is on my radar. I'll take a look ASAP and report back here and to conda-forge/f90wrap-feedstock#32

Hi @jameskermode I just wanted to check back on this issue, did you have time to take a look at it? My issue is that the lammps package depends on quippy and quippy itself depends on f90wrap, which currently prevents me from updating the lammps package to python 3.11. The alternative option is to remove quippy support from the lammps conda forge package so that we can continue with the migration, but before I do so, I wanted to cycle back with you.

Nope, I've not had time to look at this at all. I might managed next week but can't make any promises. If you would be able to dig into it and report errors here I'll be very willing to try to help resolve it.

It seems to be this part:

 f90wrap/arraydatamodule.c: In function 'PyInit_arraydata':
  f90wrap/arraydatamodule.c:171:28: error: lvalue required as left operand of assignment
    171 |   Py_TYPE(&PyFortran_Type) = &PyType_Type;
        |                            ^

Think I've figured this out. Once the PR passes for both pre- and post- Py 3.11 I'll do a new release you can use for conda-forge.

That would be great - I look forward to it.

Seems to work. v0.2.11 is being built and released now, should be on PyPI in 30 mins or so.

This still leaves #169, Windows support.

Thanks a lot - this solved the issue conda-forge/f90wrap-feedstock#36