jamesturk/scrapelib

requests incompatibility

Closed this issue · 4 comments

Seems like there's an issue with the version of requests being used. Just did a pip install scrapelib on a clean virtualenv. From the console:

(scrapelibtest)Toms-MacBook-Air:scrapelibtest tomlee$ python
Python 2.7.2 (default, Jun 20 2012, 16:23:33)
[GCC 4.2.1 Compatible Apple Clang 4.0 (tags/Apple/clang-418.0.60)] on darwin
Type "help", "copyright", "credits" or "license" for more information.

import scrapelib
Traceback (most recent call last):
File "", line 1, in
File "/Users/tomlee/Projects/scrapelibtest/lib/python2.7/site-packages/scrapelib/init.py", line 193, in
class FTPSession(requests.Session):
File "/Users/tomlee/Projects/scrapelibtest/lib/python2.7/site-packages/scrapelib/init.py", line 195, in FTPSession
requests.defaults.SCHEMAS.append('ftp')
AttributeError: 'module' object has no attribute 'defaults'

Yeah requests 1.0 was a complete break with the prior version.

I need to figure out what it means for us (they removed configuration and a
lot of other stuff)

for now you'll have to use requests<1.0 - I'll probably push out a release
that enforces this and start a new branch for requests 1.0 compat.

On Thu, Dec 20, 2012 at 9:40 PM, sbma44 notifications@github.com wrote:

Seems like there's an issue with the version of requests being used. Just
did a pip install scrapelib on a clean virtualenv. From the console:

(scrapelibtest)Toms-MacBook-Air:scrapelibtest tomlee$ python
Python 2.7.2 (default, Jun 20 2012, 16:23:33)
[GCC 4.2.1 Compatible Apple Clang 4.0 (tags/Apple/clang-418.0.60)] on
darwin
Type "help", "copyright", "credits" or "license" for more information.

import scrapelib
Traceback (most recent call last):
File "", line 1, in
File
"/Users/tomlee/Projects/scrapelibtest/lib/python2.7/site-packages/scrapelib/init.py",
line 193, in
class FTPSession(requests.Session):
File
"/Users/tomlee/Projects/scrapelibtest/lib/python2.7/site-packages/scrapelib/init.py",
line 195, in FTPSession
requests.defaults.SCHEMAS.append('ftp')
AttributeError: 'module' object has no attribute 'defaults'


Reply to this email directly or view it on GitHubhttps://github.com//issues/4.

Got it. Sorry to report a known issue! I was able to get by just fine with something cruder.

you will probably push out a release that enforces this and start a new branch for requests 1.0 compat.

where is it ? thanks!

The latest release is compatible with scrapelib 1.0, everything tagged
prior to 0.8 is for scrapelib < 1.0

On Wed, May 15, 2013 at 6:32 AM, yxlwfds notifications@github.com wrote:

you will probably push out a release that enforces this and start a new
branch for requests 1.0 compat.

where is it ? thanks!


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-17931078
.