jandelgado/jled

FadeOff leaves LED glimming

marmil opened this issue · 7 comments

When the FadeOff function reaches the last period step, the LED still glows as it is not fully switched off. There should be an implemented auto-off after end of fading time.

Library version: 4.5.1
Controller: ESP32-WROOM-32 at a small dev board (AZdelivery)
My Code:

#include "jled.h
#define PIN_LED_INSIDE 1
auto LEDInsideOn = JLed(PIN_LED_INSIDE).LowActive();

bool schalter = true;

void setup() {
  LEDInsideOn.On();
  LEDInsideOn.Update();
  delay(500);
  LEDInsideOn.FadeOff(10000);
  LEDInsideOn.Update();
}

void loop() {
  LEDInsideOn.Update();
}

I dont have the original schematic by hand and can not find it in the web. It's a LowSide switched LED in principle like this;
image

Hi,

could you please provide complete, minimal example C++ code and an schematic of the circuit you used so I can check the behaviour?

Which version of JLed are you using?

Hi,
thanks for your quick response.
I updated my original post with more information :)

I did some experiments and it seems like we hit this ESP32 problem: espressif/arduino-esp32#689

The LED stays dim on in this simple example:

#include <jled.h>       
                                                       
auto led = JLed(22).On().LowActive();                                         
void setup() { }                                                                              

void loop() {                                                                  
  led.Update();                                                                
}              

I'll provide a workaround in the next days

See #61 for a fix - does it work for you?

@marmil does the fix solve the problem?

@jandelgado Works. Thank you 👍

fix released with 4.5.2