Not compatible with Sails 0.11.x?
heysailor opened this issue · 4 comments
Installing with sails 11.5 I get the following error:
error: Error (SAILS:HOOK:SOCKETS:PARSE_VIRTUAL_REQ):: Failed to parse incoming socket.io request.
...
'Sails v0.11.x is not compatible with the socket.io/sails.io.js client SDK version you are using (0.9.0). Please see the v0.11 migration guide on http://sailsjs.org for more information.'
angular-sails [1.x] uses sails.io.js to communicate with sails backend, it appears that the version of sail.io.js you are using is not compatible. When you create a new sails project, it will drop a compatible version in your project for you. If you upgrade/migrated from an older version of sails, you will need to update sail.io.js. You can get the latest from their repo.
Sorry - this was using angular-sails 2.0 beta 3, and a fresh install of
sails 11.5 and the latest socket.io-client.
On Friday, 5 June 2015, Evan Sharp notifications@github.com wrote:
—
Reply to this email directly or view it on GitHub
#74 (comment).
Yes, well with 2.x you will not need sail.io.js. Can you inspect the connect using Chrome's devtools. You should be able to see the information sent on the handshake easily and should look something like this:
This image is from the latest sailsjs project using angular-sails 2.0.0-beta.3
In detail, the reason why this would be happening: Sails' socket hook looks on the querystring to find information about the socket connection. If the socket doesn't provide the info.... sails just assumes its 0.9.0. Knowing this, in the v2 where we are not using sail.io.js, we had to conform to their "standard" and implemented something to supply those values on the handshake. From what it looks like, your socket connection is not sending those. Since I cannot reproduce locally, I need more information.
Apologies for late reply, I've been in a remote area for a while.
You're right, there are no sails specific values being sent with the handshake:
Looking through the sails-angular code, the problem was that I'd set up the socket connection with the socket-io client before handing over to angular-sails. So angular-sails was using the provided socket connection rather than setting up with the expected sails values.
Would it be handy for others using angular-sails to explain you don't need to set up the socket, only include the socket.io client in the page?
Cheers for a very handy library.