FxCop CA1034

[collinbarrett]

Hey Jimmy,

I've been using MediatR on a couple projects for the last 6 months and love it.

I've seen in many of your examples that you use nested types often for encapsulating your commands/queries. FxCop flags the CA1034 warning when using this pattern. Is that CA1034 rule anything we should be concerned about when using MediatR?

Thanks!

[jbogard]

No that’s just a style preference.

…

On Fri, Jul 5, 2019 at 4:20 PM Collin M. Barrett ***@***.***> wrote: Hey Jimmy, I've been using MediatR on a couple projects for the last 6 months and love it. I've seen in many of your examples that you use nested types <https://github.com/jbogard/ContosoUniversity/blob/a8d396f3df0f2db85ad8fc92125a1334cee015aa/src/ContosoUniversity/Features/Course/Create.cs#L11> often for encapsulating your commands/queries. FxCop flags the CA1034 warning <https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1034-nested-types-should-not-be-visible> when using this pattern. Is that CA1034 rule anything we should be concerned about when using MediatR? Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#37?email_source=notifications&email_token=AAAZQMVWGHW6FNE7AJOS2ILP563KZA5CNFSM4H6OH7C2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5T5WQA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZQMUDYDEERJCHFVMORWLP563KZANCNFSM4H6OH7CQ> .