jeanluct/braidlab

loop.plot cannot take multiple loops

Opened this issue · 6 comments

loop.plot fails when a vector of loops is passed in a way that's not informative to the user.
Potential fixes: fail in a more informative way OR generate many axes each containing one row of the argument (not advisable) OR plot all loops on a single axis.

Commit 043b71d adds a temporary fix: assertion to make the error more transparent.

There may be something in the manual about plot now working on multiple loops.

Hm, I didn't think to check. In any case, error was ugly and non-informative (something about concatenation of coordinates in the internal getcoords function), so I pre-empted it with an assert.

I just mentioned it in case it needed modifying in the guide. It says "Some commands, such as \lstinline{plot}, do not vectorize." This seems fine as it is.

Perhaps we should close this as an issue and open a new enhancement instead to have braidlab be able to plot multiple loops - how to do that is a different discussion, I think.

We can just reclassify #133 as an enhancement. It would be good to keep this earlier discussion together with the issue.