Remove: onActivityResult
Closed this issue · 3 comments
TeamRainless commented
Why not just get rid of the onActivityResult once and for all?
How bout we just go into the place in the original code where it is called... and do something else (literally ANYTHING else) instead?
jens-muenker commented
You are right. There is no reason to support it in newer versions of this library. While translating the library, my goal was to encompass all features supported in the latest uCrop version for a seamless transition.
TeamRainless commented
It just looks ugly sitting there next to the new, clean code. It also
discourages brand new users from fully understanding how the whole system
really works.
…On Tue, Nov 14, 2023, 10:52 PM Jens Münker ***@***.***> wrote:
You are right. There is no reason to support it in newer versions of this
library. While translating the library, my goal was to encompass all
features supported in the latest uCrop version for a seamless transition.
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2KI544TJIHTLRABFPNEGDYEPRY3AVCNFSM6AAAAAA7KXNUF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJRGM4DCNBVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
jens-muenker commented
This is now in the develop-branch. (See PR #8)