If the user selects Cancel on the SaveFileDialog when closing the app it will save the mhc file anyway.

[bakerhillpins]

If the user opts to cancel their save operation when exiting by selecting the Cancel button on the SaveFileDialog it ignores the cancel and saves the file anyway.

[bakerhillpins]

So question for you: I've noticed that there are 2 saving algos going on when one exits. The first looks at the dirty flag for the upper level MazeCollection (via MazeCollectionController) and saves the maze if the user says yes. The second looks at each maze (via MazeController) and then prompts the user to save. Issue is that backing code in the 1st test actually tests all the individual mazes for dirty. So end effect is the user will never be prompted to save an individual maze on exit. Thus I can cut out all the code for the individual maze save.

I've got fixes coded up for this and one of the other bugs, I just wanted to understand what your intended user experience on exit was before I committed anything.

[jessaskey]

So I think the challenge is that it needs to be able to save Collections AND Individual mazes. But on app closing it sorta just should do this.. 1. For each maze collection in the tree, check the IsDirty flag and prompt to save if that is true. The IsDirty flag on the collection should just be a loop through each of the child Maze objects checking the IsDirty of each of those. Additionally, the IsDirty flag on the collection might be set to True if the Maze Collection name or any of its properties in the Property Grid have been changed. 2. For individual mazes in the tree (not parented under a collection)… it just checks the IsDirty flag individualy. For both of the above scenarios, there should be a FileName which includes a path to the Collection/Maze, if that is set and it is a valid path, then the program will jus save to that path. If that variable is empty or it contains a path+file that is invalid or does not exist, then it will open the Save File dialog and get a valid path and filename in order to save the file successfully. Most of this should already be there, but I can see where the internal logic that sets the IsDirty property might be broken for sure, especially after changing the Container objects around a bit to separate the controllers from the object. Application Close 1. Maze Collection * IsDirty = False - Skip the object, this assumes disk matches memory. * IsDirty = True - Prompt user if they want to save the Collection (Yes/No/Cancel) i. No – Skip the collection ii. Cancel – Abort the close operation completely iii. Yes - Is the FileName(.mhc) empty or a non-existent location on disk? * Yes – Open the Save Dialog, if the path of the filename was valid (folder location), then default to that folder location (assuming here that the filename was the issue, invalid characters or something). Filename is blank in the save dialog then. * DialogResult of Save Dialog i. Save – * Save the new Path+File into the Collection object property * Save to disk… continue back to ‘Application Close’ (which will look for subsequent Collections/Mazes with IsDirty = true before closing) ii. Cancel – Abort the close operation completely * No – Save the file and continue 1. Individual Maze (not in collection) * Same as above, but for an .mhz filename Additionally, outside of that default logic… the user *can*save an individual maze in a collection as an .mhz file by selecting the individual maze and then the buttons at the top will allow to ‘Save Maze’…. Which then will kick off the logic above at (1.)(b.)(iii.). The individual maze Path+Filename will also still be saved into the Maze Object, but that really doesn’t have any bearing on the Collection since collection saves don’t care about any individual maze Path+Filenames. Hope that is clear. 😊

[bakerhillpins]

Yikes, remind me not to ask questions. I didn't understand that you could have individual mazes not under a collection. That's the part that threw me for a loop. Going to have to see how that works with MAME too.

I'll adjust my changes to hopefully pick all this up.

[jessaskey]

So the way that is used to work and *should* still work, is that if a single maze is being run in MAME, then the ROM serializer will look at the Maze type (A,B,C,D) and serialize it into the template ROM at level 1,2,3 or 4 accordingly. The other levels are empty, but because the template ROM sets up the game to repeat, it all should be okay. From: bakerhillpins <notifications@github.com> Sent: Sunday, February 10, 2019 10:02 AM To: jessaskey/mhedit <mhedit@noreply.github.com> Cc: Jess Askey <jess@askey.org>; Comment <comment@noreply.github.com> Subject: Re: [jessaskey/mhedit] If the user selects cancel on the SaveDialog when closing the app it will save the mhc file anyway. (#11) Yikes, remind me not to ask questions. I didn't understand that you could have individual mazes not under a collection. That's the part that threw me for a loop. Going to have to see how that works with MAME too. I'll adjust my changes to hopefully pick all this up. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#11 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADgzGjqrWfEqP_b_eeflOgWNViG8pXEiks5vMFCWgaJpZM4ayR2v>.