Test failures with -ficu
Closed this issue · 7 comments
felixonmars commented
I have tried to re-enable -ficu for Arch Linux's packaging, but got the following errors, which were not present with icu disabled.
Some versions:
GHC 9.0.1
citeproc 0.4.1
text-icu 0.7.1.0
icu 69.1
Running 1 test suites...
Test suite spec: RUNNING...
[FAILED] test/csl/affix_CommaAfterQuote.txt
--- expected
+++ actual
@@
-“quote”, Hello Thing
+“quote,” Hello Thing
[FAILED] test/csl/affix_WithCommas.txt
--- expected
+++ actual
@@
John Smith, <i>Book C</i>, 2000, and David Jones, <i>Book D</i>, 2000.
-Smith, <i>Book C</i> is one source, Jones, <i>Book D</i> is another.
-Smith, <i>Book C</i>, 23 is one source, Jones, <i>Book D</i> is another.
+Smith, <i>Book C</i> is one source,; Jones, <i>Book D</i> is another.
+Smith, <i>Book C</i>, 23 is one source,; Jones, <i>Book D</i> is another.
[FAILED] test/csl/bugreports_AutomaticallyDeleteItemsFails.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
-<div class="csl-entry">
-<div class="csl-left-margin">[1]</div><div class="csl-right-inline"> J. Doe, <i>Book A</i>, 2000.</div>
-</div>
-<div class="csl-entry">
-<div class="csl-left-margin">[2]</div><div class="csl-right-inline"> J. Doe, <i>Book B</i>, 2000.</div>
-</div>
+ <div class="csl-entry">
+ <div class="csl-left-margin">[1]</div><div class="csl-right-inline"> J. Doe, <i>Book A</i>, 2000.</div>
+ </div>
+ <div class="csl-entry">
+ <div class="csl-left-margin">[2]</div><div class="csl-right-inline"> J. Doe, <i>Book B</i>, 2000.</div>
+ </div>
+ <div class="csl-entry">
+ <div class="csl-left-margin">[3]</div><div class="csl-right-inline"> R. Snoakes, <i>Book C</i>, 2000.</div>
+ </div>
@@
</div>
[FAILED] test/csl/bugreports_ChicagoAuthorDateLooping.txt
--- expected
+++ actual
@@
-(Anon.; Anon.; Manstein 1982)
+(Manstein 1982; Anon.; Anon.)
[FAILED] test/csl/bugreports_DemoPageFullCiteCruftOnSubsequent.txt
--- expected
+++ actual
@@
-Malone and U.S. Bureau of the Census, <i>Evaluating Components of International Migration: Consistency of 2000 Nativity Data</i>.
+Nolan J. Malone, U.S. Bureau of the Census, <i>Evaluating Components of International Migration: Consistency of 2000 Nativity Data</i> (New York: Routledge, 2001).
[FAILED] test/csl/bugreports_EnvAndUrb.txt
--- expected
+++ actual
@@
Baines, T S, O Benedettini and J M Kay, ‘Title One’; Baines, T S, F Gump and J M Kay, ‘Title Two’.
-See reference 1, Baines et al.
-See reference 1, Baines et al.
+See reference 1.
+See reference 1.
[FAILED] test/csl/bugreports_LegislationCrash.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry"><i>Arrêté du 23 mars 1992 relatif au programme des études conduisant au diplôme d’État d’infirmier</i>, 1992. </div>
+ <div class="csl-entry"><i>Arrêté du 23 mars 1992 relatif au programme des études conduisant au diplôme d’État d’infirmier</i>, 1992. 23 mars 1992</div>
@@
</div>
[WARNING] test/csl/bugreports_MissingItemInJoin.txt
==> Bibliography entry with no printed form: ITEM-3
[FAILED] test/csl/bugreports_NoCaseEscape.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
<div class="csl-entry">
-
- <div class="csl-block">Aalto, Alan</div>
-
- <div class="csl-left-margin"> N.d.</div><div class="csl-right-inline">“‘PIAAC-Longitudinal (PIAAC-L) 2015.’”</div>
+ <div class="csl-block">Aalto, Alan</div><div class="csl-left-margin"> N.d.a</div><div class="csl-right-inline">“‘PIAAC-Longitudinal (PIAAC-L) 2015.’”</div>
@@
</div>
- <div class="csl-entry">
- <div class="csl-left-margin">N.d.</div><div class="csl-right-inline">“PIAAC-Longitudinal (PIAAC-Lx) 2015.”</div>
+ <div class="csl-entry">
+ <div class="csl-left-margin"> N.d.b</div><div class="csl-right-inline">“PIAAC-Longitudinal (PIAAC-Lx) 2015”.</div>
@@
</div>
</div>
[FAILED] test/csl/bugreports_OldMhraDisambiguationFailure.txt
--- expected
+++ actual
@@
John Doe, <i>Book A</i>, 2000; John Doe, <i>Book B</i>, 2000.
-Doe, Book A; Doe, Book B.
+Doe; Doe.
[FAILED] test/csl/bugreports_OverwriteCitationItems.txt
--- expected
+++ actual
@@
-Title Four; Title Five
Title Two; Title Three
+Title Four; Title Five
[FAILED] test/csl/bugreports_SingleQuoteXml.txt
--- expected
+++ actual
@@
-[Cite with a composer ; O A. "hello" <i>Book Title</i>]
+[Cite with a composer ; O A. “hello” <i>Book Title</i>]
[FAILED] test/csl/bugreports_SmallCapsEscape.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
<div class="csl-entry">
-
- <div class="csl-block">Aalto, Alan</div>
-
- <div class="csl-left-margin"> N.d.</div><div class="csl-right-inline"><span style="font-variant:small-caps;">Here</span>.</div>
+ <div class="csl-block">Aalto, Alan</div><div class="csl-left-margin"> N.d.</div><div class="csl-right-inline"><span style="font-variant:small-caps;">Here</span>.</div>
@@
</div>
</div>
[WARNING] test/csl/bugreports_UndefinedInName.txt
==> Citation with no printed form: ITEM-1
[FAILED] test/csl/bugreports_ikeyOne.txt
--- expected
+++ actual
@@
-(Smith)
+(John Smith)
+(James Smith)
[FAILED] test/csl/collapse_AuthorCollapseNoDateSorted.txt
--- expected
+++ actual
@@
-(Smith 325AD, 2000)
+(Smith 325AD, 2000, )
[WARNING] test/csl/date_DateNoDateNoTest.txt
==> Citation with no printed form: ITEM-1
[FAILED] test/csl/date_YearSuffixImplicitWithNoDate.txt
--- expected
+++ actual
@@
-(John Doe n.d.-a [Accessed: June 1, 1965]; John Doe n.d.-b [Accessed: June 1, 2065])
+(John Doe n.d. [Accessed: June 1, 1965]; John Doe n.d. [Accessed: June 1, 2065])
[FAILED] test/csl/date_YearSuffixWithNoDate.txt
--- expected
+++ actual
@@
-(John Doe n.d.-a [Accessed: June 1, 1965]; John Doe n.d.-b [Accessed: June 1, 2065])
+(John Doe n.d. [Accessed: June 1, 1965]; John Doe n.d. [Accessed: June 1, 2065])
[FAILED] test/csl/disambiguate_BasedOnEtAlSubsequent.txt
--- expected
+++ actual
@@
-(Baur, Fröberg, Baur, et al. 2000<i>a</i>; Baur, Schileyko & Baur 2000<i>b</i>; Doe 2000)
+(Baur, Fröberg, Baur, et al. 2000; Baur, Schileyko & Baur 2000; Doe 2000)
[FAILED] test/csl/disambiguate_BasedOnSubsequentFormWithBackref2.txt
--- expected
+++ actual
@@
John Doe, His Book (2000); John Doe, His Other Book (2001).
Jane Roe, Her Book (1998).
-Roe, supra note 2.
+Roe, Her Book, supra note 2.
@@
Doe, His Book, supra note 1.
-Roe, supra note 2.
+Roe, Her Book, supra note 2.
[FAILED] test/csl/disambiguate_DifferentSpacingInInitials.txt
--- expected
+++ actual
@@
-Doe, His Anonymous Life (part 1); Doe, His Anonymous Life (part 2)
+Doe, J. J., His Anonymous Life (part 1); Doe, J. J., His Anonymous Life (part 2)
[FAILED] test/csl/disambiguate_DisambiguationHang.txt
--- expected
+++ actual
@@
(Caminiti, Johnson, Burnod, Galli, & Ferraina 1990a)
(Caminiti, Johnson, Burnod, Galli, & Ferraina 1990b)
-(Caminiti, Johnson, & Urbano 1990)
+(Caminiti, Johnson, & Urbano 1990a)
[FAILED] test/csl/disambiguate_IncrementalExtraText.txt
--- expected
+++ actual
@@
Yost Trisk
-John Smith, Book One
-John Smith, Book Two
+John Smith, Book One, ed. 3
+John Smith, Book Two, ed. 4
@@
John Smith, Complete Works, ed. 5
John Smith, Complete Works, ed. 6
[FAILED] test/csl/disambiguate_InitializeWithButNoDisambiguation.txt
--- expected
+++ actual
@@
-(Doe, 1965a, 1965b)
+(Doe, 1965b; Doe, 1965a)
[FAILED] test/csl/disambiguate_PrimaryNameWithNonDroppingParticle.txt
--- expected
+++ actual
@@
-(dos Santos et al. 2016; Santos et al. 2020)
+(R. G. dos Santos et al. 2016; B. W. L. Santos et al. 2020)
[FAILED] test/csl/disambiguate_PrimaryNameWithParticle.txt
--- expected
+++ actual
@@
-dos Smith; Smith
+dos Smith, A.; Smith, B.
[FAILED] test/csl/disambiguate_YearCollapseWithInstitution.txt
--- expected
+++ actual
@@
-(Smith Co 2000a; 2000b; 2000c)
+(Smith Co 2000a, 2000b, 2000c)
(Smith Co 2000b)
(Smith Co 2000c)
[FAILED] test/csl/disambiguate_YearSuffixAtTwoLevels.txt
--- expected
+++ actual
@@
-Smith, Jones & Brown (1986a); Smith, Jones & Brown (1986b); Smith, Jones, Brown, et al. (1986a); Smith, Jones, Brown, et al. (1986b)
+Smith et al. (1986a); Smith et al. (1986b); Smith et al. (1986c); Smith et al. (1986d)
[FAILED] test/csl/disambiguate_YearSuffixWithEtAlSubequent.txt
--- expected
+++ actual
@@
-(Smith 2000a; 2000b; 2000c)
+(Smith 2000a, 2000b, 2000c)
(Smith 2000b)
(Smith 2000c)
[FAILED] test/csl/flipflop_LeadingMarkupWithApostrophe.txt
--- expected
+++ actual
@@
-<i>Insha’Allah</i> is an Arabic phrase meaning ‘God willing’. Another Arabic word is <i>bukra</i>. Aalto
+<i>Insha’Allah</i> is an Arabic phrase meaning “God willing.” Another Arabic word is <i>bukra</i>. Aalto
[FAILED] test/csl/flipflop_OrphanQuote.txt
--- expected
+++ actual
@@
-Nation of "Positive Obligations " of State under the European Convention on Human Rights (1)
+Nation of “Positive Obligations ” of State Under the European Convention on Human Rights (1)
[FAILED] test/overrides/fullstyles_ABdNT.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry">COLE, S. J.; MOORE, R. Hydrological modelling using raingauge- and radar-based estimators of areal rainfall. <b>Journal of Hydrology</b>, v. 358, n. 3–4, p. 159–181, 2008.</div>
+ <div class="csl-entry">COLE, S. J.; MOORE, R. Hydrological modelling using raingauge- and radar-based estimators of areal rainfall. <b>Journal of Hydrology</b>, v. 358, n. 3-4, p. 159–181, 2008.</div>
@@
</div>
[FAILED] test/csl/fullstyles_ChicagoAuthorDateSimple.txt
--- expected
+++ actual
@@
<div class="csl-entry">Doe, John, Jane Roe, Alvin Asthma, Bob Bronchitis, Chris Cold, Don Dropsy, Ernie Enteritis, et al. 1993. <i>Book D</i>.</div>
- <div class="csl-entry">---. 1994. <i>Book E</i>.</div>
+ <div class="csl-entry">Doe, John, Jane Roe, Alvin Asthma, Bob Bronchitis, Chris Cold, Don Dropsy, Ernie Enteritis, et al. 1994. <i>Book E</i>.</div>
@@
</div>
[FAILED] test/csl/integration_FirstReferenceNoteNumberPositionChange.txt
--- expected
+++ actual
@@
-Snoakes, “Life of Snoakes” (1902).
Doe, “Life of Doe” (1901).
Roe, “Life of Roe” (1900).
-Doe, supra note 2.
-Roe, supra note 3.
+Doe, supra note 1.
+Roe, supra note 2.
+Snoakes, “Life of Snoakes” (1902).
[FAILED] test/csl/integration_IbidOnInsert.txt
--- expected
+++ actual
@@
(Doe p. 12)
(Noakes p. 34)
-(Ibid.)
@@
(Snoakes p. 45)
+(ibid.)
[WARNING] test/extra/issue_37.txt
==> Bibliography entry with no printed form: doeA
[WARNING] test/extra/issue_38.txt
==> Bibliography entry with no printed form: diaz2015
==> Bibliography entry with no printed form: diaz2016
[FAILED] test/csl/label_EditorTranslator1.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry">1. Иванов И.И. Пример оформления книги с редактором и переводчиком в одном лице : вид издания : in 5 vols. Vol. 2 / И.И. Иванов, П.П. Петров, С.С. Сидоров; ed & trans. Р.Р. Романов Дополнительно. – Тюмень: Дом, 2013. – 10. – 100 p.</div>
+ <div class="csl-entry">1. Иванов И.И.
+. Пример оформления книги с редактором и переводчиком в одном лице : вид издания : in 5 vols. Vol. 2 / И.И. Иванов, П.П. Петров, С.С. Сидоров; ed & trans. Р.Р. Романов Дополнительно. – Тюмень: Дом, 2013. – 10. – 100 p.</div>
@@
</div>
[FAILED] test/csl/magic_CapitalizeFirstOccurringTerm.txt
--- expected
+++ actual
@@
-And
+and
[FAILED] test/csl/magic_PunctuationInQuoteNested.txt
--- expected
+++ actual
@@
-Doe. <i>“Book A.”</i> 1900.
+Doe. <i>“Book A”</i>. 1900.
[WARNING] test/csl/magic_StripPeriodsTrueShortForm.txt
==> Bibliography entry with no printed form: ITEM-1
==> Bibliography entry with no printed form: ITEM-2
[WARNING] test/csl/magic_SubsequentAuthorSubstituteOfTitleField.txt
==> Citation with no printed form: item-3
[FAILED] test/csl/magic_TermCapitalizationWithPrefix.txt
--- expected
+++ actual
@@
This has been said. Ibid.
-Ibid.
+ibid.
[FAILED] test/csl/name_BibliographyNameFormNeverShrinks.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
-<div class="csl-entry"><i>Smith, Jimmie</i></div>
-<div class="csl-entry"><i>Smith, Reggie</i></div>
+ <div class="csl-entry"><i>Smith, Jimmie</i></div>
+ <div class="csl-entry"><i>Smith, Reggie</i></div>
@@
</div>
[FAILED] test/csl/name_CiteGroupDelimiterWithYearSuffixCollapse2.txt
--- expected
+++ actual
@@
-(Aalto 2015a,b; Bartleby 2010; Aalto 2015c–e)
+(Aalto 2015a–e; Bartleby 2010)
[FAILED] test/csl/name_DelimiterAfterInverted.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry">Australian Government Productivity Commission & New Zealand Productivity Commission</div>
+ <div class="csl-entry">Australian Government Productivity Commission, & New Zealand Productivity Commission</div>
@@
<div class="csl-entry">Weinstock, R., Leong, G. B., & Silva, J. A.</div>
</div>
[FAILED] test/csl/name_EtAlWithCombined.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
<div class="csl-entry">John Doe。</div>
- <div class="csl-entry">——著，Ziggy Zither等點校。</div>
+ <div class="csl-entry">——著，Ziggy Zither 等點校。</div>
@@
<div class="csl-entry">田中太郎, Yossarian Yoda, 等翻譯員。</div>
</div>
[FAILED] test/csl/name_HebrewAnd.txt
--- expected
+++ actual
@@
-תפוחו תפוז
+תפוח ו תפוז
[FAILED] test/csl/name_InTextMarkupInitialize.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry"><b>Doe</b>, <b>J.</b> Q.</div>
- <div class="csl-entry"><b>Doe</b>, <b>J.</b>-Q.</div>
+ <div class="csl-entry"><b>Doe</b>, <b>John</b>. Q.</div>
+ <div class="csl-entry"><b>Doe</b>, <b>John</b>.-Q.</div>
@@
</div>
[FAILED] test/csl/name_InTextMarkupNormalizeInitials.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry"><b>Doe</b>, <b>J.</b> Q.</div>
- <div class="csl-entry"><b>Doe</b>, <b>J.</b>-Q.</div>
+ <div class="csl-entry"><b>Doe</b>, <b>J</b>. Q.</div>
+ <div class="csl-entry"><b>Doe</b>, <b>J</b>.-Q.</div>
@@
</div>
[FAILED] test/csl/number_OrdinalSpacing.txt
--- expected
+++ actual
@@
-Blah blah. 7th, pp. 3–8DD<i>ed</i>
+Blah blah. 7th, p. 3rd–8thDD<i>ed</i>
[FAILED] test/csl/number_PlainHyphenOrEnDashAlwaysPlural.txt
--- expected
+++ actual
@@
-His Anonymous Life (1) pages 1–2 (cs:text) vs His Anonymous Life (1) pages 1–2 (cs:number); His Anonymous Life (2) pages i–ix (cs:text) vs His Anonymous Life (2) pages i–ix (cs:number); His Anonymous Life (3) page 3-B (cs:text) vs His Anonymous Life (3) page 3-B (cs:number); His Anonymous Life (4) page Michaelson-Morely (cs:text) vs His Anonymous Life (4) page Michaelson-Morely (cs:number)
+His Anonymous Life (1) pages 1–2 (cs:text) vs His Anonymous Life (1) pages 1–2 (cs:number); His Anonymous Life (2) pages i–ix (cs:text) vs His Anonymous Life (2) pages i–ix (cs:number); His Anonymous Life (3) page 3-B (cs:text) vs His Anonymous Life (3) page 3-B (cs:number); His Anonymous Life (4) pages Michaelson–Morely (cs:text) vs His Anonymous Life (4) pages Michaelson–Morely (cs:number)
[FAILED] test/csl/position_FirstTrueOnlyOnce.txt
--- expected
+++ actual
@@
Appleton “Tom Swift and His Electric Runabout” (1910).
-Ibid. p. 23.
+ibid. p. 23.
[FAILED] test/csl/position_IbidInText.txt
--- expected
+++ actual
@@
Appleton “Tom Swift and His Electric Runabout” (1910).
Bloggs “A Very Short Book Indeed” (2012).
-Ibid.
+Appleton “Tom Swift and His Electric Runabout” (1910).
[FAILED] test/csl/position_IbidSeparateCiteSameNote.txt
--- expected
+++ actual
@@
[citation3-item1-note2] ibid. page 33.
-[citation4-item2-note3] Bloggs “A Very Short Book Indeed” (2012); [citation4-item1-note3] Appleton supra note 1.
-[citation5-item1-note4] Appleton supra note 1 page 99.
-[citation6-item1-note4] Appleton supra note 1.
+[citation4-item2-note3] Bloggs “A Very Short Book Indeed” (2012); [citation4-item1-note3] Appleton supra.
+[citation5-item1-note4] Appleton supra page 99.
+[citation6-item1-note4] Appleton supra.
@@
[citation7-item1-note4] ibid.
[FAILED] test/csl/position_IbidWithLocator.txt
--- expected
+++ actual
@@
Appleton “Tom Swift and His Electric Runabout” (1910).
-Ibid. p. 23.
+ibid. p. 23.
[FAILED] test/csl/position_IbidWithMultipleSoloCitesInBackref.txt
--- expected
+++ actual
@@
Álvarez
-Ibid.
+ibid.
[FAILED] test/csl/position_IfIbidWithLocatorIsTrueThenIbidIsTrue.txt
--- expected
+++ actual
@@
Appleton “Tom Swift and His Electric Runabout” (1910).
-Ibid.
+ibid.
[FAILED] test/csl/position_NearNoteSameNote.txt
--- expected
+++ actual
@@
Plain+Vanilla:Book-A; Near+Ibid:Book-A
Plain+Vanilla:Book-B
-Plain+Vanilla:Book-B; Plain+Vanilla:Book-A
+Near+Ibid:Book-B; Plain+Vanilla:Book-A
[FAILED] test/csl/position_ResetNoteNumbers.txt
--- expected
+++ actual
@@
Book A (note 1)
-Book C (note 1)
-Book A, n 1 (note 2)
@@
ibid (note 2)
-Book C, n 1 (note 3)
-Book A, n 1 (note 3)
-Book C, n 1 (note 4)
+Book C (note 3)
+ibid (note 1)
+Book A, n 1 (note 2)
+ibid (note 3)
+Book C, n 3 (note 4)
@@
Book A, n 1 (note 5)
[FAILED] test/csl/punctuation_FullMontyQuotesIn.txt
--- expected
+++ actual
@@
“semicolon”; colon
-“exclamation!” colon
-“question?” colon
+“exclamation”! colon
+“question”? colon
@@
“comma,”: colon
@@
“semicolon”; period
-“exclamation!” period
-“question?” period
-“comma,.” period
+“exclamation”! period
+“question”? period
+“comma,”. period
@@
@@
“semicolon”; semicolon
-“exclamation!”; semicolon
-“question?”; semicolon
+“exclamation”!; semicolon
+“question”?; semicolon
@@
“comma,”; semicolon
@@
ENDING IN EXCLAMATION
-“colon!” exclamation
-“period.!” exclamation
-“semicolon!” exclamation
-“exclamation!” exclamation
-“question?!” exclamation
-“comma,!” exclamation
+“colon”! exclamation
+“period.”! exclamation
+“semicolon”! exclamation
+“exclamation”! exclamation
+“question”?! exclamation
+“comma,”! exclamation
@@
ENDING IN QUESTION
-“colon?” question
-“period.?” question
-“semicolon?” question
-“exclamation!?” question
-“question?” question
-“comma,?” question
+“colon”? question
+“period.”? question
+“semicolon”? question
+“exclamation”!? question
+“question”? question
+“comma,”? question
@@
@@
“colon”:, comma
-“period.,” comma
+“period.”, comma
@@
“semicolon”;, comma
-“exclamation!,” comma
-“question?,” comma
+“exclamation”!, comma
+“question”?, comma
@@
“comma,” comma
[FAILED] test/csl/quotes_QuotesUnderQuotesFalse.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry"> 'Title with ‘quotes’ in it',.</div>
+ <div class="csl-entry"> ’Title with ‘quotes’ in it’,.</div>
@@
</div>
[FAILED] test/csl/sort_BibliographyCitationNumberDescending.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry">[1] Book 008</div>
- <div class="csl-entry">[2] Book 007</div>
- <div class="csl-entry">[3] Book 005</div>
- <div class="csl-entry">[4] Book 002</div>
- <div class="csl-entry">[5] Book 006</div>
- <div class="csl-entry">[6] Book 004</div>
- <div class="csl-entry">[7] Book 003</div>
- <div class="csl-entry">[8] Book 001</div>
+ <div class="csl-entry">[8] Book 008</div>
+ <div class="csl-entry">[7] Book 007</div>
+ <div class="csl-entry">[6] Book 005</div>
+ <div class="csl-entry">[5] Book 002</div>
+ <div class="csl-entry">[4] Book 006</div>
+ <div class="csl-entry">[3] Book 004</div>
+ <div class="csl-entry">[2] Book 003</div>
+ <div class="csl-entry">[1] Book 001</div>
@@
</div>
[FAILED] test/csl/sort_BibliographyCitationNumberDescendingViaCompositeMacro.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry">[4] Aaaa</div>
- <div class="csl-entry">[3] Bbbb</div>
- <div class="csl-entry">[2] Xxxx</div>
- <div class="csl-entry">[1] Zzzz</div>
+ <div class="csl-entry">[1] Aaaa</div>
+ <div class="csl-entry">[2] Bbbb</div>
+ <div class="csl-entry">[3] Xxxx</div>
+ <div class="csl-entry">[4] Zzzz</div>
@@
</div>
[FAILED] test/csl/sort_BibliographyCitationNumberDescendingViaMacro.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry">[8] Book One</div>
- <div class="csl-entry">[7] Book Three</div>
- <div class="csl-entry">[6] Book Four</div>
- <div class="csl-entry">[5] Book Six</div>
- <div class="csl-entry">[4] Book Two</div>
- <div class="csl-entry">[3] Book Five</div>
- <div class="csl-entry">[2] Book Seven</div>
- <div class="csl-entry">[1] Book Eight</div>
+ <div class="csl-entry">[1] Book One</div>
+ <div class="csl-entry">[2] Book Three</div>
+ <div class="csl-entry">[3] Book Four</div>
+ <div class="csl-entry">[4] Book Six</div>
+ <div class="csl-entry">[5] Book Two</div>
+ <div class="csl-entry">[6] Book Five</div>
+ <div class="csl-entry">[7] Book Seven</div>
+ <div class="csl-entry">[8] Book Eight</div>
@@
</div>
[FAILED] test/csl/sort_ChicagoYearSuffix1.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
<div class="csl-entry">Beijing Zoo. 1974a. Observations on the breeding of the giant panda and the raising of its young [in Chinese]. <i>Acta Zoologica Sinica</i> 20: 154–61.</div>
- <div class="csl-entry">---. 1974b. On the diseases of the giant panda and their preventive and curative measures [in Chinese]. <i>Acta Zoologica Sinica</i> 20: 139–47.</div>
+ <div class="csl-entry">Beijing Zoo. 1974b. On the diseases of the giant panda and their preventive and curative measures [in Chinese]. <i>Acta Zoologica Sinica</i> 20: 139–47.</div>
@@
</div>
[FAILED] test/csl/sort_ChicagoYearSuffix2.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
<div class="csl-entry">Beijing Zoo. 1974a. Observations on the breeding of the giant panda and the raising of its young [in Chinese]. <i>Acta Zoologica Sinica</i> 20: 154–61.</div>
- <div class="csl-entry">---. 1974b. On the diseases of the giant panda and their preventive and curative measures [in Chinese]. <i>Acta Zoologica Sinica</i> 20: 139–47.</div>
+ <div class="csl-entry">Beijing Zoo. 1974b. On the diseases of the giant panda and their preventive and curative measures [in Chinese]. <i>Acta Zoologica Sinica</i> 20: 139–47.</div>
@@
</div>
[FAILED] test/csl/sort_ConditionalMacroDates.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry">Title 3</div>
@@
<div class="csl-entry">Title 1</div>
<div class="csl-entry">Title 2</div>
+ <div class="csl-entry">Title 3</div>
@@
</div>
[FAILED] test/csl/sort_LeadingApostropheOnNameParticle.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
<div class="csl-entry">d’Wander, W</div>
- <div class="csl-entry">de’ Frinkle, B</div>
+ <div class="csl-entry">de’Frinkle, B</div>
@@
<div class="csl-entry">in ’t Horvath, P A B</div>
[FAILED] test/csl/sort_NameVariable.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
- <div class="csl-entry">John Doe</div>
@@
<div class="csl-entry">Jacob [F]linders</div>
+ <div class="csl-entry">John Doe</div>
@@
<div class="csl-entry">Jane Roe</div>
</div>
[WARNING] test/csl/sort_OmittedBibRefMixedNumericStyle.txt
==> Bibliography entry with no printed form: ITEM-2
[FAILED] test/csl/sort_OmittedBibRefMixedNumericStyle.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
<div class="csl-entry">1. Anderson, Book One</div>
- <div class="csl-entry">2. [CSL STYLE ERROR: reference with no printed form.]</div>
+ <div class="csl-entry">[CSL STYLE ERROR: reference with no printed form.]</div>
@@
<div class="csl-entry">3. Crane, Book Two</div>
</div>
[WARNING] test/csl/sort_OmittedBibRefNonNumericStyle.txt
==> Bibliography entry with no printed form: ITEM-2
[FAILED] test/csl/sort_OmittedBibRefNonNumericStyle.txt
--- expected
+++ actual
@@
<div class="csl-bib-body">
<div class="csl-entry">Anderson, Book One</div>
+ <div class="csl-entry">[CSL STYLE ERROR: reference with no printed form.]</div>
@@
<div class="csl-entry">Crane, Book Two</div>
</div>
[FAILED] test/csl/sort_RangeUnaffected.txt
--- expected
+++ actual
@@
-<sup>1</sup>
<sup>1–3</sup>
+<sup>3</sup>
[WARNING] test/csl/substitute_SubstituteOnlyOnceTermEmpty.txt
==> Citation with no printed form: ITEM-1
[FAILED] test/csl/substitute_SubstituteOnlyOnceTermEmpty.txt
--- expected
+++ actual
@@
-Content:
+[CSL STYLE ERROR: reference with no printed form.]
[WARNING] test/overrides/variables_TitleShortOnShortTitleNoTitleCondition.txt
==> Citation with no printed form: ITEM-3
CPU time: 206.60s
CATEGORY PASS FAIL ERROR SKIP
abbreviations 2 0 0 0 |++++++++++++++++++++|
affix 7 2 0 0 |+++++++++++++++ |
bugreports 71 11 0 0 |+++++++++++++++++ |
collapse 20 1 0 0 |+++++++++++++++++++ |
condition 17 0 0 0 |++++++++++++++++++++|
date 99 2 0 0 |+++++++++++++++++++ |
decorations 7 0 0 0 |++++++++++++++++++++|
disambiguate 60 11 0 0 |++++++++++++++++ |
display 5 0 0 0 |++++++++++++++++++++|
etal 4 0 0 0 |++++++++++++++++++++|
flipflop 17 2 0 0 |+++++++++++++++++ |
form 3 0 0 0 |++++++++++++++++++++|
fullstyles 3 2 0 0 |++++++++++++ |
group 7 0 0 0 |++++++++++++++++++++|
integration 12 2 0 0 |+++++++++++++++++ |
issue 8 0 0 0 |++++++++++++++++++++|
label 18 1 0 0 |++++++++++++++++++ |
locale 23 0 0 0 |++++++++++++++++++++|
locator 6 0 0 0 |++++++++++++++++++++|
magic 37 3 0 0 |++++++++++++++++++ |
name 105 7 0 0 |++++++++++++++++++ |
nameattr 97 0 0 0 |++++++++++++++++++++|
nameorder 6 0 0 0 |++++++++++++++++++++|
namespaces 1 0 0 0 |++++++++++++++++++++|
number 18 2 0 0 |++++++++++++++++++ |
page 9 0 0 0 |++++++++++++++++++++|
plural 7 0 0 0 |++++++++++++++++++++|
position 8 8 0 0 |++++++++++ |
punctuation 15 1 0 0 |++++++++++++++++++ |
quotes 3 1 0 0 |+++++++++++++++ |
simplespace 1 0 0 0 |++++++++++++++++++++|
sort 55 11 0 0 |++++++++++++++++ |
sortseparator 1 0 0 0 |++++++++++++++++++++|
substitute 6 1 0 0 |+++++++++++++++++ |
testers 2 0 0 0 |++++++++++++++++++++|
textcase 29 0 0 0 |++++++++++++++++++++|
unicode 1 0 0 0 |++++++++++++++++++++|
variables 5 0 0 0 |++++++++++++++++++++|
virtual 1 0 0 0 |++++++++++++++++++++|
------------- ----- ----- ----- -----
(all) 796 68 0 0
Test suite spec: FAIL
Test suite logged to: dist/test/citeproc-0.4.1-spec.log
0 of 1 test suites (0 of 1 test cases) passed.
jgm commented
You'll see that a lot of these tests fail normally too (they are "expected failures").
It would be good to have a diff of the regular log vs the icu log.
felixonmars commented
I see. Here it goes:
--- no-icu.out 2021-07-23 03:00:55.542006438 +0800
+++ icu.out 2021-07-23 02:59:28.640411541 +0800
@@ -117,8 +117,8 @@
--- expected
+++ actual
@@
--[Cite with a composer ; O A. "hello" <i>Book Title</i>]
-+[Cite with a composer ; O A. “hello” <i>Book Title</i>]
+-[Cite with a composer ; O A. "hello" <i>Book Title</i>]
++[Cite with a composer ; O A. “hello” <i>Book Title</i>]
[FAILED] test/csl/bugreports_SmallCapsEscape.txt
--- expected
@@ -331,9 +331,9 @@
+++ actual
@@
<div class="csl-bib-body">
-- <div class="csl-entry">1. Иванов И.И. Пример оформления книги с редактором и переводчиком в одном лице : вид издания : in 5 vols. Vol. 2 / И.И. Иванов, П.П. Петров, С.С. Сидоров; ed & trans. Р.Р. Романов Дополнительно. – Тюмень: Дом, 2013. – 10. – 100 p.</div>
-+ <div class="csl-entry">1. Иванов И.И.
-+. Пример оформления книги с редактором и переводчиком в одном лице : вид издания : in 5 vols. Vol. 2 / И.И. Иванов, П.П. Петров, С.С. Сидоров; ed & trans. Р.Р. Романов Дополнительно. – Тюмень: Дом, 2013. – 10. – 100 p.</div>
+- <div class="csl-entry">1. Иванов И.И. Пример оформления книги с редактором и переводчиком в одном лице : вид издания : in 5 vols. Vol. 2 / И.И. Иванов, П.П. Петров, С.С. Сидоров; ed & trans. Р.Р. Романов Дополнительно. – Тюмень: Дом, 2013. – 10. – 100 p.</div>
++ <div class="csl-entry">1. Иванов И.И.
++. Пример оформления книги с редактором и переводчиком в одном лице : вид издания : in 5 vols. Vol. 2 / И.И. Иванов, П.П. Петров, С.С. Сидоров; ed & trans. Р.Р. Романов Дополнительно. – Тюмень: Дом, 2013. – 10. – 100 p.</div>
@@
</div>
@@ -704,6 +704,19 @@
@@
</div>
+[FAILED] test/csl/sort_ConditionalMacroDates.txt
+--- expected
++++ actual
+@@
+ <div class="csl-bib-body">
+- <div class="csl-entry">Title 3</div>
+@@
+ <div class="csl-entry">Title 1</div>
+ <div class="csl-entry">Title 2</div>
++ <div class="csl-entry">Title 3</div>
+@@
+ </div>
+
[FAILED] test/csl/sort_LeadingApostropheOnNameParticle.txt
--- expected
+++ actual
@@ -715,6 +728,19 @@
@@
<div class="csl-entry">in ’t Horvath, P A B</div>
+[FAILED] test/csl/sort_NameVariable.txt
+--- expected
++++ actual
+@@
+ <div class="csl-bib-body">
+- <div class="csl-entry">John Doe</div>
+@@
+ <div class="csl-entry">Jacob [F]linders</div>
++ <div class="csl-entry">John Doe</div>
+@@
+ <div class="csl-entry">Jane Roe</div>
+ </div>
+
[WARNING] test/csl/sort_OmittedBibRefMixedNumericStyle.txt
==> Bibliography entry with no printed form: ITEM-2
[FAILED] test/csl/sort_OmittedBibRefMixedNumericStyle.txt
@@ -761,7 +787,7 @@
[WARNING] test/overrides/variables_TitleShortOnShortTitleNoTitleCondition.txt
==> Citation with no printed form: ITEM-3
-CPU time: 147.09s
+CPU time: 206.60s
CATEGORY PASS FAIL ERROR SKIP
abbreviations 2 0 0 0 |++++++++++++++++++++|
@@ -795,7 +821,7 @@
punctuation 15 1 0 0 |++++++++++++++++++ |
quotes 3 1 0 0 |+++++++++++++++ |
simplespace 1 0 0 0 |++++++++++++++++++++|
-sort 57 9 0 0 |+++++++++++++++++ |
+sort 55 11 0 0 |++++++++++++++++ |
sortseparator 1 0 0 0 |++++++++++++++++++++|
substitute 6 1 0 0 |+++++++++++++++++ |
testers 2 0 0 0 |++++++++++++++++++++|
@@ -804,8 +830,7 @@
variables 5 0 0 0 |++++++++++++++++++++|
virtual 1 0 0 0 |++++++++++++++++++++|
------------- ----- ----- ----- -----
-(all) 798 66 0 0
-We have passed all the CSL tests we expect to...
-Test suite spec: PASS
+(all) 796 68 0 0
+Test suite spec: FAIL
Test suite logged to: dist/test/citeproc-0.4.1-spec.log
-1 of 1 test suites (1 of 1 test cases) passed.
+0 of 1 test suites (0 of 1 test cases) passed.
So that test/csl/sort_ConditionalMacroDates.txt and test/csl/sort_NameVariable.txt are the differences.
(Also CPU time seems to be much longer. Not sure if that is expected...)
jgm commented
Longer CPU time is interesting indeed. I think that says that there's not much point using the icu flag.
jgm commented
I think these differences arise because, with unicode-collation we default to the "shifted" variable weighting, unless a variable weighting is explicitly specified. But with icu we have a different default, apparently. This could be changed.
felixonmars commented
I have retried the test suite for three times each, on a low-load build host instead:
-ficu:
CPU time: 79.82s
CPU time: 73.40s
CPU time: 74.09s
Avg: 75.77s
-f-icu:
CPU time: 89.70s
CPU time: 70.53s
CPU time: 88.13s
Avg: 82.79s
So...indeed icu is slightly faster here. The result above should be an accident :P
Sorry for the confusion!
jgm commented
With this update tests should no longer fail with icu.
jgm commented
Interestingly, although the tests pass on my macos installation with icu 69.1, they fail on our CI with ubuntu and 66.1. Not going to worry about that, I think.