jgm/zip-archive

Restrictive binary version on hackage

qrilka opened this issue · 6 comments

Hackage version has binary < 0.6 and binary-0.6 is 1.5 months old. Github version does not have this restriction.
Time to publish new package version?

jgm commented

You're mistaken. The github version does have the restriction.

The code does not currently compile with binary 0.6. The reason
is that two combinators that zip-archive used were removed in binary
0.6. So the zip-archive code needs to be rewritten to work around
this, and I haven't had time to do that yet.

+++ qrilka [Nov 05 12 10:05 ]:

Hackage version has binary < 0.6 and binary-0.6 is 1.5 months old.
Github version does not have this restriction.
Time to publish new package version?

--
Reply to this email directly or [1]view it on GitHub.
[Jshd8sI44GVrKZBvymxqKKDACoNTj_4rssLCcEZZX35xxSDLPRHneWFyG5ANUsSF.gif]

References

  1. #7

Ooop, my fault - I've looked into my forked version and it was a bit too old.
I'll look into it perhaps I could get it working with 0.6

jgm commented

OK! See #4

+++ qrilka [Nov 05 12 11:40 ]:

Ooop, my fault - I've looked into my forked version and it was a bit
too old.
I'll look into it perhaps I could get it working with 0.6

--
Reply to this email directly or [1]view it on GitHub.
[Jshd8sI44GVrKZBvymxqKKDACoNTj_4rssLCcEZZX35xxSDLPRHneWFyG5ANUsSF.gif]

References

  1. #7 (comment)

What do you think about Lennart's comment kolmodin/binary#17 (comment) ?

jgm commented

+++ qrilka [Nov 05 12 22:07 ]:

What do you think about Lennart's comment [1]kolmodin/binary#17 ?

Yes, I'm sure it is possible to rewrite without lookahead.
This may not be worth it if it makes the code less modular,
but it's certainly something I'd planned to look into when
I have a chance.

Just haven't gotten a chance yet.

gentoo currently uses such hack:

https://github.com/gentoo-haskell/gentoo-haskell/blob/master/dev-haskell/zip-archive/files/zip-archive-0.1.2.1-binary-0.6.patch

It uses only lookAheadM, which is simple to implement via alternative instance (<|>).