jish/pre-commit

obey .jshintignore?

Closed this issue · 4 comments

I have .jshintrc and .jshintignore files on the root of the project folder. Just the way .jshintrc is read, can we also read .jshintignore and ignore checks on the files and folders listed there?

Do you think it would be a good addition? Is this already achievable in some way?

jish commented

"Do you think it would be a good addition?"

Yes, I think it would be a good addition.

"Is this already achievable in some way?"

Unfortunately, no :(

@madhums can you include small example or point us to repository that has this file?

so we do not support .jshintignore and we wont have it because it would require reimplementing this https://github.com/jshint/jshint/blob/master/src/cli.js#L410-L413 in ruby ... but then we have the nest best thing - support for .gitignore and your project already has https://github.com/madhums/node-express-mongoose-demo/blob/master/.gitignore:

node_modules/

closing this ticket as wontfix (I already spent hours on investigating it, it could be implemented but I do not think as it duplicates the .gitignore functionality which we get for free from git