jish/pre-commit

migrate plugins to new repositories

Opened this issue · 15 comments

follow up for #152, as we have https://github.com/pre-commit-plugins we should consider separating plugins to separate repositories.

@jish I would start with checks that do not have any dependencies and are not included by default .. did not had time to look which ones fit best

something like #164 would be a good point to start, @jish?

jish commented

Yea, I agree. The PHP and Go checks seem like good candidates for plugins.

@jish in https://github.com/pre-commit-plugins I get You don't appear to have permission to create repositories for this organization. Sorry about that.

and I can not transfer rights of https://github.com/mpapis/pre-commit-php because of You don't have admin rights to pre-commit-plugins

jish commented

@mpapis I changed the access controls on pre-commit-plugins, can you check if you have more permission now?

https://github.com/pre-commit-plugins/pre-commit-php

can not push to the new repo:

ERROR: Permission to pre-commit-plugins/pre-commit-php.git denied to mpapis.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

go to https://github.com/orgs/pre-commit-plugins/teams and add the new repo to core team - or add me to Owners/admins

jish commented

try now? :x

it worked :)

and @jish can push the gem now too: http://rubygems.org/gems/pre-commit-php

and #180 is merged, the php plugin will work now outside of the pre-commit gem - it's a good start :)

@jish I would say this is one of the steps towards 1.0.0 what do you think?

jish commented

Yea, definitely :)