jkuri/bore

Incomplete error handling

dstd opened this issue · 2 comments

dstd commented

I suppose there is a dangling error case – it is handled, but the control flow continues as if there was no error, resulting to a nil pointer dereference.

https://github.com/jkuri/bore/blob/master/server/ssh.go#L202

But I'm not sure what is the right way to fix it – continue or break

jkuri commented

you are right, it is continue. can you please open a pr for that?

jkuri commented