jleclanche/fireplace

[test]Missing steps in attack cycle when Truesilver Champion triggers off Shadowboxer

tonyyyye opened this issue · 3 comments

An interesting test with shadowboxer

I recalled an interesting test the other day and made a pytest case for it.
Somehow it didn't work and I don't know why.

[fireplace.actions]: <Hero ('Anduin Wrynn')> attacks <Minion ('Wisp')>
[fireplace.actions]: <Weapon ('Truesilver Champion')> triggers off <Action: Attack(<Attack.ATTACKER>=<Hero ('Anduin Wrynn')>, <Attack.DEFENDER>=<Minion ('Wisp')>)> from <Hero ('Anduin Wrynn')>
[fireplace.actions]: <Weapon ('Truesilver Champion')> triggering <TargetedAction: Heal(<Heal.AMOUNT>=2)> targeting [<Hero ('Anduin Wrynn')>]
[fireplace.actions]: <Weapon ('Truesilver Champion')> heals <Hero ('Anduin Wrynn')> for 1
[fireplace.actions]: <Minion ('Shadowboxer')> triggers off <TargetedAction: Heal(<Heal.AMOUNT>=2)> from <Weapon ('Truesilver Champion')>
[fireplace.actions]: <Minion ('Shadowboxer')> triggering <TargetedAction: Hit(<Hit.AMOUNT>=1)> targeting [<Minion ('Wisp')>]
[fireplace.actions]: <Minion ('Shadowboxer')> triggering <TargetedAction: Predamage(<Predamage.AMOUNT>=1)> targeting [<Minion ('Wisp')>]
[fireplace.actions]: <Minion ('Shadowboxer')> triggering <TargetedAction: Damage()> targeting [<Minion ('Wisp')>]
[fireplace.actions]: <Hero ('Anduin Wrynn')> triggering <TargetedAction: Hit(<Hit.AMOUNT>=4)> targeting [<Minion ('Wisp')>]
[fireplace.actions]: <Hero ('Anduin Wrynn')> triggering <TargetedAction: Predamage(<Predamage.AMOUNT>=4)> targeting [<Minion ('Wisp')>]
[fireplace.actions]: <Hero ('Anduin Wrynn')> triggering <TargetedAction: Damage()> targeting [<Minion ('Wisp')>]

The dead minion is supposed to be removed and attacker can attack again.

I don't think fireplace has the full attack cycle implemented for situations like these.

The cleave attacking with different Buffs also confuses me a lot. Attack action triggers many listeners, so I need to figure out what the procedure is when a charactor attacks.

It is not an issue any more since the recent update of Shadowboxer in version 12.0