jmurzy/react-router-native

Make compatible with RN 0.32

jonathanglasmeyer opened this issue · 2 comments

React Native 0.32 changes the behaviour of NavigationHeader: it's not positioned absolutely anymore. We need to change the layout of styles.wrapper, similar to how its done in this UIExplorer example diff (just needs flexDirection: 'column-reverse').

This will break layout compatibility with RN < 0.32. Also existing layouts need to remove their padding/margin on their "Page" components which was used to pull them below the Header.

I have refactored quite a few things that also included support for v0.32 and onwards but didn't want to push a patch because we are blocked by this.

In the meanwhile, #37 is a great patch. Thanks, Jonathan. 🚀

🍺

Woa these babel configs in package.json files are a PITA. I was thinking of handling this via a postinstall script that'd remove the entries from the offending package jsons.