joaomgcd/JoinChrome

Join pop out window not working

Closed this issue · 13 comments

betterbydesign commented

I noticed after updating Chrome now when I try to open Join in its own pop out window it doesn't do anything. Theres no Chrome error about it being blocked either.

joaomgcd commented

Which version of Chrome are you using?

betterbydesign commented

Version 102.0.5005.61 (Official Build) (arm64)

joaomgcd commented

Hhm, I just tried that on my Windows PC and it still works.. Is that on Linux? Mac?

betterbydesign commented
medlir commented

I was having this issue on Windows 10 as well but I WAS getting an error in the inspect dev console for the extension about it being out of bounds.

Resolved by Chrome menu, More Tools, Extensions, Join, Details, Inspect Views, "join.html", Application tab in dev console, Local Storage, wiped out the popoutWidth and popoutHeight values, which allowed it to fall back on the default hard-coded values, and it successfully was able to open the popout immediately after nuking those.

Edit: Though resizing the window off the default size immediately breaks it again. Not sure what that's about as the error is Unchecked runtime.lastError: Invalid value for bounds. Bounds must be at least 50% within visible screen space. and values of 886x819 are certainly within my screen bounds and visible.

Edit 2: Okay, looking further, seems to be a problem with the top and left attributes of the popout window create... it's setting the left to screen.width - 230 and the top to Math.round((screen.height / 2) - (height /2)) so presumably if you resize the popout to wider than 460, more than 50% will be off-screen regardless of height? Though on switching my HDMI switch for second monitor back to my desktop from my laptop it's now working seemingly after being resized... only it's creating the resized popup on the second screen, leading me to think it's getting confused about available screen space in general.

joaomgcd commented

Oh, thanks for the tip. Seems like I need to try and fix that! Does that fix your issue though @Satori83 ?

betterbydesign commented

Interestingly enough one of Macbooks was working still, the other had the issue but following the steps listed to remove pop out values fixed it. Thanks guys!

joaomgcd commented

Glad it worked! :) Thanks for the input!

clubtech commented

@joaomgcd will you be releasing a fix for this? I'm still having this issue with version 1.8.23 of the extension.

joaomgcd commented

@clubtech did the solution mentioned above not work for you?

clubtech commented

@joaomgcd it fixed it for me but would it be possible to release a permanent fix for this via the chrome store?

joaomgcd commented

Yes, I need to put out a permanent fix for this. Ideally the window should always be created in a usable space...

betterbydesign commented