jodhman/react-eyedrop

Eyedrop does not work on background image

sapirost opened this issue · 4 comments

sapirost commented

When I'm trying to use eyedrop on an element with background-image I keep getting this value:
{rgb: 'rgb(255, 255, 255)', hex: '#ffffff'}
Is it possible to inspect background-image? if not, is there any workaround to achieve the expected results?

Thanks in advance!

jodhman commented

Hey, @sapirost ! I'll have a look at it and get back to you. Give me a few moments.

EDIT
Alright. Just confirmed the issue you're having. I know how it can get resolved, just need some free time to implement it, maybe over the weekend.
If you need it to work asap, I'd recommend turning towards the img HTML tag, since it's currently supported. I'll make sure to update you in this thread as soon as a new version is published.

sapirost commented

Thanks, @jodhman ! I really appreciate it
It is not urgent, I'll wait for a new version :)

jodhman commented

Sorry for the delay. Just pushed a new version 5.3.0. It should work with any HTML element. Let me know if it works for you, or if you run into any other issues!

Just bear in mind that images that are loaded from foreign domains without the Allow-Origin header will throw a CORS error.

jodhman commented

Closing this as time has passed & targeting HTML elements with a background property now functions.

Please don't hesitate to comment in this issue if you're still having issues.