johnbrett/hapi-level

Version of level too old to build on Windows 10

Closed this issue · 3 comments

Hi John,
I'm trying out your hapi-level-sample project on Windows (thanks!) but it won't build on Windows 10 (with VS 2015) due to the reference to level 0.18.x. That version of level relies on an old node-gyp which is incompatible with Win10/VS2015 (and Win 8.1 I'd guess). I forked your repo and changed package.json to refer to level version 1.3.x. It then builds ok and hapi-level-sample seems to run fine.

Conor

Hey conor. Will update this. Level had a rewrite after I made that project,
which would corrupt all old databases so was hesitant to update hapi level.
I'll make the upgrade now, and update the hapi level sample project when I
get a chance. If you'd like anything covered in the project let me know as
well!

On Fri, 14 Aug 2015 17:24 conoro notifications@github.com wrote:

Hi John,
I'm trying out your hapi-level-sample project on Windows (thanks!) but it
won't build on Windows 10 (with VS 2015) due to the reference to level
0.18.x. That version of level relies on an old node-gyp which is
incompatible with Win10/VS2015 (and Win 8.1 I'd guess). I forked your repo
and changed package.json to refer to level version 1.3.x. It then
builds ok and hapi-level-sample seems to run fine.

Conor


Reply to this email directly or view it on GitHub
#1.

Actually, do you want to submit a pull request to hapi level with the
updated version? Can help you with it if you like?

On Sat, 15 Aug 2015 16:30 John Brett johnbrett7@gmail.com wrote:

Hey conor. Will update this. Level had a rewrite after I made that
project, which would corrupt all old databases so was hesitant to update
hapi level. I'll make the upgrade now, and update the hapi level sample
project when I get a chance. If you'd like anything covered in the project
let me know as well!

On Fri, 14 Aug 2015 17:24 conoro notifications@github.com wrote:

Hi John,
I'm trying out your hapi-level-sample project on Windows (thanks!) but it
won't build on Windows 10 (with VS 2015) due to the reference to level
0.18.x. That version of level relies on an old node-gyp which is
incompatible with Win10/VS2015 (and Win 8.1 I'd guess). I forked your repo
and changed package.json to refer to level version 1.3.x. It then
builds ok and hapi-level-sample seems to run fine.

Conor


Reply to this email directly or view it on GitHub
#1.

Ah I figured there might be some sort of backwards-compatibility concerns alright. PR issued.

Will play more now!