policy-bot

policy-bot is a GitHub App for enforcing approval policies on pull requests. It does this by creating a status check, which can be configured as a required status check.

While GitHub natively supports required reviews, policy-bot provides more complex approval features:

Require reviews from specific users, organizations, or teams
Apply rules based on the files, authors, or branches involved in a pull request
Combine multiple approval rules with and and or conditions
Automatically approve pull requests that meet specific conditions

Behavior is configured by a file in each repository. policy-bot also provides a UI to view the detailed approval status of any pull request.

Configuration
Security
Deployment
Development
Contributing
License

Configuration

By default, the behavior of the bot is configured by a .policy.yml file at the root of the repository. When running your own instance of the server, a different file name and location can be configured. The configured name and location will be used instead of the default location.

If the file does not exist, the policy-bot status check is not posted. This means it is safe to enable policy-bot on all repositories in an organization.
The .policy.yml file is read from the most recent commit on the target branch of each pull request.

policy.yml Specification

The overall policy is expressed by:

Lists of rule definitions
A set of policies that combine the rules or define additional options

Consider the following example, which allows changes to certain paths without review, but all other changes require review from the palantir/devtools. Any member of the palantir organization can also disapprove changes.

# the high level policy
policy:
  approval:
    - or:
      - the devtools team has approved
      - only staging files have changed
  disapproval:
    requires:
      organizations:
        - "palantir"

# the list of rules
approval_rules:
  - name: the devtools team has approved
    requires:
      count: 1
      teams:
        - "palantir/devtools"
  - name: only staging files have changed
    if:
      only_changed_files:
        paths:
          - "staging/.*"
    requires:
      count: 0

Remote Policy Configuration

You can also define a remote policy by specifying a repository, path, and ref (only repository is required). Instead of defining a policy key, you would define a remote key. Only 1 level of remote configuration is supported by design.

# The remote repository to read the policy file from. This is required, and must
# be in the form of "org/repo-name". Must be a public repository.
remote: org/repo-name

# The path to the policy config file in the remote repository. If none is
# specified, the default path in the server config is used.
path: path/to/policy.yml

# The branch (or tag, or commit hash) that should be used on the remote
# repository. If none is specified, the default branch of the repository is used.
ref: master

Approval Rules

Each list entry in approval_rules has the following specification:

# "name" is required, and is used to reference rules in the "policy" block
name: "example rule"

# "if" specifies a set of predicates that must be true for the rule to apply.
# This block, and every condition within it are optional. If the block does not
# exist, the rule applies to every pull request.
if:
  # "changed_files" is satisfied if any file in the pull request matches any
  # regular expression in the "paths" list. If the "ignore" list is present,
  # files in the pull request matching these regular expressions are ignored
  # by this rule.
  changed_files:
    paths:
      - "config/.*"
      - "server/views/.*\\.tmpl"
    ignore:
      - "config/special\\.file"

  # "only_changed_files" is satisfied if all files changed by the pull request
  # match at least one regular expression in the list.
  only_changed_files:
    paths:
      - "config/.*"

  # "has_author_in" is satisfied if the user who opened the pull request is in
  # the users list or belongs to any of the listed organizations or teams.
  has_author_in:
    users: ["user1", "user2", ...]
    organizations: ["org1", "org2", ...]
    teams: ["org1/team1", "org2/team2", ...]

  # "has_contributor_in" is satisfied if any commits on the pull request have
  # an author or committer in the users list or that belong to any of the
  # listed organizations or teams.
  has_contributor_in:
    users: ["user1", "user2", ...]
    organizations: ["org1", "org2", ...]
    teams: ["org1/team1", "org2/team2", ...]

  # "only_has_contributors_in" is satisfied if all of the commits on the pull
  # request have an author or committer in the users list or that belong to
  # any of the listed organizations or teams.
  only_has_contributors_in:
    users: ["user1", "user2", ...]
    organizations: ["org1", "org2", ...]
    teams: ["org1/team1", "org2/team2", ...]

  # "author_is_only_contributor", when true, is satisfied if all commits in the
  # pull request are authored by and committed by the user who opened the pull
  # request. When false, it is satisfied if at least one commit in the pull
  # request was authored or committed by another user.
  author_is_only_contributor: true

  # "targets_branch" is satisfied if the target branch of the pull request
  # matches the regular expression
  targets_branch:
    pattern: "^(master|regexPattern)$"

  # "modified_lines" is satisfied if the number of lines added or deleted by
  # the pull request matches any of the listed conditions. Each expression is
  # an operator (one of '<' or '>'), an optional space, and a number.
  modified_lines:
    additions: "> 100"
    deletions: "> 100"
    total: "> 200"

  # "has_successful_status" is satisfied if the status checks that are specified
  # are marked successful on the head commit of the pull request.
  has_successful_status:
    - "status-name-1"
    - "status-name-2"
    - "status-name-3"

  # "has_labels" is satisfied if the pull request has the specified labels
  # applied
  has_labels:
    - "label-1"
    - "label-2"

# "options" specifies a set of restrictions on approvals. If the block does not
# exist, the default values are used.
options:
  # If true, approvals by the author of a pull request are considered when
  # calculating the status. False by default.
  allow_author: false

  # If true, the approvals of someone who has committed to the pull request are
  # considered when calculating the status. The pull request author is considered
  # a contributor. If allow_author and allow_contributor would disagree, this option
  # always wins. False by default.
  allow_contributor: false

  # If true, pushing new commits to a pull request will invalidate existing
  # approvals for this rule. False by default.
  invalidate_on_push: false

  # If true, "update merges" do not invalidate approval (if invalidate_on_push
  # is enabled) and their authors/committers do not count as contributors. An
  # "update merge" is a merge commit that was created in the UI or via the API
  # and merges the target branch into the pull request branch. These are
  # commonly created by using the "Update branch" button in the UI.
  ignore_update_merges: false

  # If present, commits authored and committed by users meeting the conditions
  # are ignored for the purposes of approval. This means the users will not
  # count as contributors and their commits will not invalidate approval if
  # invalidate_on_push is enabled. Both the author and the committer must match
  # the conditions to ignore the commit. This option has security implications,
  # see the README for more details.
  ignore_commits_by:
    users: ["bulldozer[bot]"]
    organizatons: ["org1']
    teams: ["org1/team1"]

  # Automatically request reviewers when a Pull Request is opened
  # if this rule is pending, there are no assigned reviewers, and if the
  # Pull Request is not in Draft.
  # Reviewers are selected based on the set of requirements for this rule
  # and reviewers can be augmented using the mode option.
  request_review:
    # False by default
    enabled: true
    # mode modifies how reviewers are selected. `all-users` will request all users
    # who are able to approve the pending rule. `random-users` selects a small
    # set of random users based on the required count of approvals. `teams` will 
    # request teams to review if possible. Defaults to 'random-users'.
    mode: all-users|random-users|teams

  # "methods" defines how users may express approval.
  methods:
    # If a comment contains a string in this list, it counts as approval. Use
    # the "comment_patterns" option if you want to match full comments. The
    # default values are shown.
    comments:
      - ":+1:"
      - "👍"
    # If a comment matches a regular expression in this list, it counts as
    # approval. Defaults to an empty list.
    comment_patterns:
      - "^Signed-off by \\s+$"
    # If true, GitHub reviews can be used for approval. Default is true.
    github_review: true

# "requires" specifies the approval requirements for the rule. If the block
# does not exist, the rule is automatically approved.
requires:
  # "count" is the number of required approvals. The default is 0, meaning no
  # approval is necessary.
  count: 1

  # A user must be in the list of users or belong to at least one of the given
  # organizations or teams for their approval to count for this rule.
  users: ["user1", "user2"]
  organizations: ["org1", "org2"]
  teams: ["org1/team1", "org2/team2"]

  # allows approval by admins of the org or repository
  admins: true
  # allows approval by users who have write on the repository
  write_collaborators: true

Approval Policies

The approval block in the policy section defines a list of rules that must all be true:

policy:
  approval:
    - rule1
    - rule2
    - rule3
    - ...

Each list entry may be the name of a rule, or one of the following conjunctions:

or:
  - rule1
  - rule2
  - ...

and:
  - rule1
  - rule2
  - ...

Conjunctions can contain more conjunctions (up to a maximum depth of 5):

- or:
    - rule1
    - rule2
    - and:
        - rule3
        - rule4

Disapproval

Disapproval allows users to explicitly block pull requests if certain changes must be made. Any member of in the set of allowed users can disapprove a change or revoke another user's disapproval.

Unlike approval, all disapproval options are specified as part of the policy. Effectively, there is a single disapproval rule. The disapproval policy has the following specification:

# "disapproval" is the top-level key in the policy block.
disapproval:
  # "options" sets behavior related to disapproval. If it does not exist, the
  # defaults shown below are used.
  options:
    # "methods" defines how users set and revoke disapproval.
    methods:
      # "disapprove" sets the methods for disapproval.
      disapprove:
        comments:
          - ":-1:"
          - "👎"
        github_review: true

      # "revoke" sets the methods for revoking disapproval. Usually, these will
      # match the methods used by approval rules.
      revoke:
        comments:
          - ":+1:"
          - "👍"
        github_review: true

  # "requires" sets the users that are allowed to disapprove. If it is not set,
  # disapproval is not enabled.
  requires:
    users: ["user1", "user2"]
    organizations: ["org1", "org2"]
    teams: ["org1/team1", "org2/team2"]

Testing and Debugging Policies

Sometimes it is useful to test if a given policy file is valid, especially in a CI environment.

An API endpoint exists at /api/validate to validate the syntax of the yaml and policy configuration, however it cannot validate that the rules are semantically correct for a given use case.

The API can be used as such:

$ curl https://policybot.domain/api/validate -XPUT -T path/to/policy.yml
{"message":"failed to parse approval policy: failed to parse subpolicies for 'and': policy references undefined rule 'the devtools team has approved', allowed values: [the devtools team has]","version":"1.12.5"}

You can examine the HTTP response code to automatically detect failures

$ rcode=$(curl https://policybot.domain/api/validate -XPUT -T path/to/policy.yml -s -w "%{http_code}" -o /tmp/response)
$ if [[ "${rcode}" -gt 299 ]]; then cat /tmp/response && exit 1; fi

Caveats and Notes

There are several additional behaviors that follow from the rules above that are worth mentioning.

Disapproval is Disabled by Default

You must set at least one of the disapproval.requires fields to enable disapproval. Without setting one of these fields, GitHub reviews that request changes have no effect on the policy-bot status.

`or`, `and`, and `if` (Rule Predicates)

If the if block of a rule (the predicate) is not satisfied, the rule is marked as "skipped". Skipped rules interact with or and and as follows:

An and block containing only skipped rules is also skipped
An or block containing only skipped rules is also skipped

Effectively, skipped rules are treated as if they don't exist.

Cross-organization Membership Tests

policy-bot allows approval rules to reference organizations and teams that are not in the organization that owns the repository where the rules appear. In this case, policy-bot must be installed on all referenced organizations.

Update Merges

For a commit on a branch to count as an "update merge" for the purpose of the ignore_update_merges option, the following must be true:

The commit must have exactly two parents
The commit must have the committedViaWeb property set to true
The first parent must exist in the pull request while the second parent must not exist in the pull request (meaning it is on the target branch)

These will all be true after updating a branch using the UI, but historic merges on long-running branches or merges created with the API may not be ignored. If this happens, you will need to reapprove the pull request.

This feature has security implications.

Private Repositories

policy-bot works with private repositories, but currently does not support pull requests from private forks of private repositories due to GitHub API limitations. Please file an issue if this functionality is important to you.

Automatically Requesting Reviewers

policy-bot can automatically request reviewers for all pending rules when Pull Requests are opened by setting the request_review option.

The mode enum modifies how reviewers are selected. There are currently three supported options:

all-users to request all users who can approve
random-users to randomly select the number of users that are required
teams to request teams for review. Teams must be repository collaborators with at least read access.

options:
  request_review:
    enabled: true
    mode: all-users|random-users|teams

The set of requested reviewers will not include the author of the Pull Request or users who are not collaborators on the repository.

Automatically Requesting Reviewers Example

Given the following example requirement rule,

  requires:
    count: 2
    users: ["user1", "user2"]
    organizations: ["org1", "org2"]
    teams: ["org1/team1", "org2/team2"]

policy-bot will attempt to request 2 reviewers randomly from the expanded set of users of in

["user1", "user2", "users in org1", "users in org2", "users in org1/team1", "users in org2/team"]

Where the Pull Request Author and any non direct collaborators have been removed from the set.

Security

While policy-bot can be used to implement security controls on GitHub repositories, there are important limitations to be aware of before adopting this approach.

Status Checks

policy-bot reports approval status to GitHub using commit statuses. While statuses cannot be deleted, they can be overwritten by any user with write access to a repository. policy-bot contains an auditing feature to detect this case and rewrite the correct status, but a well-timed attempt can still approve and merge a pull request before policy-bot can detect the problem. Organizations concerned about this case should monitor and alert on the relevant audit logs.

This issue can also be minimized by limiting write access and making contributions from forks.

Comment Edits

GitHub users with sufficient permissions can edit the comments of other users, possibly chaning an unrelated comment into one that enables approval. policy-bot also contains audting for this event, but as with statuses, a well-timed edit can approve and merge a pull request before policy-bot can detect the problem. Organizations concerned about this case should monitor and alert on the relevant audit logs.

This issue can also be minimized by only using GitHub reviews for approval, at the expense of removing the ability to self-approve pull requests.

Commit Users

GitHub associates commits with users by mapping the email address in a commit to email addresses associated with GitHub user accounts. policy-bot then uses the GitHub username to evaluate user-based rules and options. There are two failure modes in this process:

If GitHub does not recognize either the author or committer email of a commit, policy-bot cannot evaluate the commit with respect to user-based rules and the commit is effectively ignored.
If emails are manipulated when creating a commit, a user can trick GitHub and policy-bot into attributing the commit to a different user.

If using GitHub Enterprise, both of these issues are avoidable by using the commit-current-user-check pre-receive hook.

Update Merge Conflicts

When using the ignore_update_merges option, policy-bot cannot tell the difference between clean merges and merges that contain conflict resolution. This means that a user who carefully crafts a pull request to generate a conflict can use the web conflict editor to add unapproved changes to the file containing the conflict.

Depending on the author of the merge commits, it may be possible to avoid this issue by using the ignore_commits_by option in combination with the commit-current-user-check pre-receive hook.

Deployment

policy-bot is easy to deploy in your own environment as it has no dependencies other than GitHub. It is also safe to run multiple instances of the server, making it a good fit for container schedulers like Nomad or Kubernetes.

We provide both a Docker container and a binary distribution of the server:

Binaries: https://bintray.com/palantir/releases/policy-bot
Docker Images: https://hub.docker.com/r/palantirtechnologies/policy-bot/

A sample configuration file is provided at config/policy-bot.example.yml. Certain values may also be set by environment variables; these are noted in the comments in the sample configuration file.

GitHub App Configuration

To configure policy-bot as a GitHub App, these general options are required:

User authorization callback URL: http(s)://<your-policy-bot-domain>/api/github/auth
Webhook URL: http(s)://<your-policy-bot-domain>/api/github/hook
Webhook secret: A random string that matches the value of the github.app.webhook_secret property in the server configuration

The app requires these permissions:

Permission	Access	Reason
Repository contents	Read-only	Read configuration and commit metadata
Checks	Read-only	Read check run results
Repository administration	Read-only	Read admin team(s) membership
Issues	Read-only	Read pull request comments
Repository metadata	Read-only	Basic repository data
Pull requests	Read & write	Receive pull request events, read metadata. Assign reviewers
Commit status	Read & write	Post commit statuses
Organization members	Read-only	Determine organization and team membership

The app should be subscribed to these events:

Check run
Issue comment
Pull request
Pull request review
Status

There is a logo.png provided if you'd like to use it as the GitHub application logo. The background color is #4d4d4d.

Operations

policy-bot uses go-baseapp and go-githubapp, both of which emit standard metrics and structured log keys. Please see those projects for details.

Development

To develop policy-bot, you will need a Go installation.

Run style checks and tests

./godelw verify

Running the server locally

# copy and edit the server config
cp config/policy-bot.example.yml config/policy-bot.yml

./godelw run policy-bot server

config/policy-bot.yml is used as the default configuration file
The server is available at http://localhost:8080/

Running the server via docker

# copy and edit the server config
cp config/policy-bot.example.yml config/policy-bot.yml

# build the docker image
./godelw docker build --verbose

docker run --rm -v "$(pwd)/config:/secrets/" -p 8080:8080 palantirtechnologies/policy-bot:latest

This will mount the path relative path config/ which should contain the modified config file policy-bot.yml
The server is available at http://localhost:8080/

Example Policy Files

Example policy files can be found in config/policy-examples

Contributing

Contributions and issues are welcome. For new features or large contributions, we prefer discussing the proposed change on a GitHub issue prior to a PR.

License

This library is made available under the Apache 2.0 License.

johnwiseheart/policy-bot