joshwcomeau/beatmapper

Latest master version does not compile

Closed this issue · 4 comments

Hello, I'm entering the world of open source. :)

Latest master version does not compile.
cloned repository
npm install
npm run start

Firstly warning is raised:

Also there was warning regarding typescript

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.2.1 <3.5.0

YOUR TYPESCRIPT VERSION: 3.9.7

Please only submit bug reports when using the officially supported version.

And then compilation error:

TypeScript error in /Users/krzysztofszajowski/development/beatmapper/src/components/DifficultyTag/DifficultyTag.tsx(53,17):
Type of property 'defaultProps' circularly references itself in mapped type 'Pick<ForwardRefExoticComponent<Pick<Pick<any, Exclude<keyof ReactDefaultizedProps<StyledComponentInnerComponent<WithC>, ComponentPropsWithRef<StyledComponentInnerComponent<WithC>>>, any>> & Partial<...>, any> & { ...; } & WithChildrenIfReactComponentClass<...>>, "defaultProps" | ... 2 more ... | "$$typeof">'.  TS2615

There is already a issue opened in typescript repo:
microsoft/TypeScript#37597

upgrading types for styled components to version
"@types/styled-components": "^5.1.7",
solved the issue

Well, I have no write access to create branch which is a must to raise a pull request. Can you grant me access? To keep it stable we should apply some validation, like pre push hook that runs test :)

Well, I have no write access to create branch which is a must to raise a pull request.

So the typical flow for the open-source projects I've been a part of is that you'd fork the repo, push your branch there, and open a PR comparing across forks. There's a guide on how to do this on the Github docs.

To keep it stable we should apply some validation, like pre push hook that runs test :)

100% agree, but yeah I really don't have the bandwidth right now to do much with this project. Busy trying to start a company and afford groceries 😅 My hope is that by the summer I'll be able to dedicate some time to this project, would love to implement 90/360 modes, and improve the general resiliency of the program

In the meantime I'll lock the dependency version to solve this problem

Should be fixed now 👍