jto/validation

Implicit syntax is automatically added

julienrf opened this issue · 4 comments

Please separate the implicit conversions defined at the package level or in companion objects so that they are not added to the implicit scope automatically. They can cause ambiguous implicit resolutions if the developer already imports, for instance cats.syntax.cartesian._.

I did not try using the v2 stuff along with cats and did not notice the issue, thanks for reporting!

Hi, you forgot implicit definitions in companion objects like these: https://github.com/jto/validation/blob/v2.0/validation-core/src/main/scala/Rule.scala#L164-L173

It was intentional, I don't see how these could cause any kind of conflicts (SyntaxCombine is completely independent from cats)

Ok, no problem.