URLs are Case Sensitive and are processed incorrectly by Canonical Rails
Closed this issue · 8 comments
kevinryantao commented
My URL is https://www.neueve.com/content/6/S2/S7 however Canonical Rails is outputting the canonical version as https://www.neueve.com/content/6/s2/s7.
This is incorrect, and URLs are case sensitive.
The bug is the "downcase" on line 32 of tag_helper.rb:
raw "#{canonical_protocol}#{host}#{port}#{path_without_html_extension}#{trailing_slash_if_needed}#{whitelisted_query_string}".downcase
Please delete the .downcase thanks!
jumph4x commented
Please cite your sources when you claim that URLs are case sensitive,
thanks.
…On Mon, Mar 25, 2019, 12:18 AM Kevin Ryan Tao ***@***.***> wrote:
My URL is https://www.neueve.com/content/6/S2/S7 however Canonical Rails
is outputting the canonical version as
https://www.neueve.com/content/6/s2/s7.
This is incorrect, and URLs are case sensitive.
The bug is the "downcase" on line 32 of tag_helper.rb:
raw "#{canonical_protocol}#{host}#{port}#{path_without_html_extension}#{trailing_slash_if_needed}#{whitelisted_query_string}".downcase
Please delete the .downcase thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#53>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGq6kshWY5FZOMNI46J10HusmjNZGVnks5vaHhegaJpZM4cGOI->
.
jumph4x commented
W3 is a pretty good one:
https://www.w3.org/TR/WD-html40-970708/htmlweb.html
On Mon, Mar 25, 2019 at 1:10 AM Denis Ivanov <denis@downshiftlabs.com>
wrote:
… Please cite your sources when you claim that URLs are case sensitive,
thanks.
On Mon, Mar 25, 2019, 12:18 AM Kevin Ryan Tao ***@***.***>
wrote:
> My URL is https://www.neueve.com/content/6/S2/S7 however Canonical Rails
> is outputting the canonical version as
> https://www.neueve.com/content/6/s2/s7.
>
> This is incorrect, and URLs are case sensitive.
>
> The bug is the "downcase" on line 32 of tag_helper.rb:
>
> raw "#{canonical_protocol}#{host}#{port}#{path_without_html_extension}#{trailing_slash_if_needed}#{whitelisted_query_string}".downcase
>
> Please delete the .downcase thanks!
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#53>, or mute the
> thread
> <https://github.com/notifications/unsubscribe-auth/AAGq6kshWY5FZOMNI46J10HusmjNZGVnks5vaHhegaJpZM4cGOI->
> .
>
--
Denis Ivanov
Downshift Labs, Consultant
jumph4x commented
Would you like to submit a pull request that avoids downcasing but also
guards against incorrectly cased inbound links?
On Mon, Mar 25, 2019 at 1:47 AM Denis Ivanov <denis@downshiftlabs.com>
wrote:
… W3 is a pretty good one:
https://www.w3.org/TR/WD-html40-970708/htmlweb.html
On Mon, Mar 25, 2019 at 1:10 AM Denis Ivanov ***@***.***>
wrote:
> Please cite your sources when you claim that URLs are case sensitive,
> thanks.
>
> On Mon, Mar 25, 2019, 12:18 AM Kevin Ryan Tao ***@***.***>
> wrote:
>
>> My URL is https://www.neueve.com/content/6/S2/S7 however Canonical
>> Rails is outputting the canonical version as
>> https://www.neueve.com/content/6/s2/s7.
>>
>> This is incorrect, and URLs are case sensitive.
>>
>> The bug is the "downcase" on line 32 of tag_helper.rb:
>>
>> raw "#{canonical_protocol}#{host}#{port}#{path_without_html_extension}#{trailing_slash_if_needed}#{whitelisted_query_string}".downcase
>>
>> Please delete the .downcase thanks!
>>
>> —
>> You are receiving this because you are subscribed to this thread.
>> Reply to this email directly, view it on GitHub
>> <#53>, or mute the
>> thread
>> <https://github.com/notifications/unsubscribe-auth/AAGq6kshWY5FZOMNI46J10HusmjNZGVnks5vaHhegaJpZM4cGOI->
>> .
>>
>
--
Denis Ivanov
Downshift Labs, Consultant
--
Denis Ivanov
Downshift Labs, Consultant
tomhughes commented
Having just run into this I'd be happy to open a PR but I'm not sure what you mean by the second part about guarding against incorrectly cased inbound links... How would it know if the link was incorrectly cased and what would it do about it? An incorrectly cased link is presumably going to lead to a 404 from rails anyway?
kevinryantao commented
I agree with Tom. For instance for this page, the correct URL is:
https://github.com/jumph4x/canonical-rails/issues/53
When you go to:
https://github.com/jumph4x/canonical-rails/issueS/53,
or:
https://github.com/juMph4x/canoNical-rails/isSues/53
the result is a 404 as expected.
However https://github.com/juMph4x/canoNical-rails/issues/53 does work. My proposed edit is to simply delete the ".downcase" on that one line.
jumph4x commented
Will review soon.
…On Mon, Jun 24, 2019, 3:30 PM Kevin Ryan Tao ***@***.***> wrote:
I agree with Tom. For instance for this page, the correct URL is:
#53 <#53>
When you go to:
https://github.com/jumph4x/canonical-rails/issueS/53,
or:
https://github.com/juMph4x/canoNical-rails/isSues/53
the result is a 404 as expected.
However #53 <#53> does
work. My proposed edit is to simply delete the ".downcase" on that one line.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#53?email_source=notifications&email_token=AAA2V2T67WMSV3YZ64DGCNTP4FDILA5CNFSM4HAY4I7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYONIIY#issuecomment-505205795>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA2V2QFXCFKIU72QN7NCL3P4FDILANCNFSM4HAY4I7A>
.
jumph4x commented
I see your point.
jumph4x commented