Modernize dependencies, squash warnings?

Question

Modernize dependencies, squash warnings?

Closed this issue 4 years ago · 8 comments

While working on #11, #12, I've found some things annoying.

The following warnings end up in end users test logs:

plugin.py:168: DeprecationWarning: This method will be removed in future versions. Use 'tree.iter()' or 'list(tree.iter())' instead.

just what it says?

PytestDeprecationWarning: direct construction of CheckLinks has been deprecated, please use CheckLinks.from_parent

require whatever version introduces from_parent

Less pressing, but still annoying are our test cases:

PytestExperimentalApiWarning: testdir.copy_example is an experimental api that may change over time

don't use copy_example... just shutil.copy into testdir?

Finally, keeping 3.5 and 2.7 happy is annoying

perhaps drop them?
...and start testing on 3.9-nightly?
- the MutableMappingpocalypse hits html5lib, requests-cache, etc. however
probably can't do both at once

Answer 1 · 2020-04-29T20:53:08.000Z

Given that 2.7 is past EOL, I say we drop it. Python 3.5 is still supported in JupyterLab, so I say we keep it for now. The others I don't see as blockers for release.

Answer 2 · 2020-04-29T21:44:23.000Z

I don't think any of them are release blockers... Just stuff that bothered me while down in the guts of the thing, and to create a little SEO juice for the actual error message texts. One thing I forgot to mention would be the ability to use lxml if available, since html5lib can use it transparently... Though the parsing is rather naive at present, and should probably be lru cached, at least, before doing _yet more_ dependency stuff.

…

On Wed, Apr 29, 2020, 16:53 Steven Silvester ***@***.***> wrote: Given that 2.7 is past EOL, I say we drop it. Python 3.5 is still supported in JupyterLab, so I say we keep it for now. The others I don't see as blockers for release. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCREAEVNDICKLW4SJXQLRPCHUFANCNFSM4MT53L7Q> .

Answer 3 · 2020-11-04T21:17:06.000Z

Hello, this project looks really useful, should I try to fix the deprication errors?

Answer 4 · 2020-11-04T21:24:31.000Z

@AnnaDinaburgVulikh That would be marvelous!

I think folk have thus far been kinda willing to deal with it, since it's "just" docs, but clean runs benefit everyone!

Answer 5 · 2020-11-06T07:36:40.000Z

Hi @bollwyvl , made the fix.

Answer 6 · 2020-11-06T13:15:08.000Z

Ah, is that the only thing outstanding? Super! PR away, though CI might well not run due to an change on Travis-CI... but good to let folk know/discuss.

Answer 7 · 2020-11-06T19:00:26.000Z

Hi @blink1073 , would you like to merge the fix for the deprecation warning?
Are any adjustments needed due to the change on Travis-CI?

Answer 8 · 2020-11-06T22:14:34.000Z

We set up Github Actions in #24, can you please open a pull request with you change @AnnaDinaburgVulikh?