jviereck/regexp.js

Case-insensitive unicode matches?

glyphobet opened this issue · 4 comments

Does it support case-insensitive unicode matches? For example, in vanilla JavaScript, you can do this:

/ü/i.exec('ü')
["ü"]
/ü/i.exec('Ü')
["Ü"]

There are tests for greek letters here:

https://github.com/jviereck/regexp.js/blob/master/test.js#L178

I've tested your characters on the console and they match :). Therefore, I am going to close this PR.

@jviereck Off-topic, but is there any reason you’re using String.fromCharCode? You could just use escape sequences.

E.g. String.fromCharCode(945)'\u03B1'.

Cool. Great presentation, by the way.

You could just use escape sequences.

Just had not thought about using them - thanks for bringing this up :)

Closing this PR as the feature seems to be implemented.