karrot-dev/karrot-frontend

Edit button inside activity edit preview should not be there

brnsolikyl opened this issue · 2 comments

I found that when editing a series of activities and pressing the Preview button, there's also an edit button there and it's actionable. This creates quite a confusion!

image

Ah, I had found that, but when I told @tiltec about it, I couldn't recreate it... and the code has the logic to not show the edit button if it's a preview... at least in the bit we looked at....

Here's the fix --> it's this line

<ActivityItem :activity="previewActivity" />
should have the preview attribute set (which was probably like it from when I added that feature)