Crashes with Swift 5.7 and Xcode14

Question

Crashes with Swift 5.7 and Xcode14

Closed this issue 2 years ago · 6 comments

obrhoff commented 2 years ago

I'm seeing this crash with Get 1.0.3 on an iOS App (code got generated with CreateAPI).

Answer 1 · 2022-09-17T19:22:17.000Z

Are you implementing this method (didCreateTask) in your code? Which thread does it get called on?

Answer 2 · 2022-09-17T21:23:53.000Z

Those methods are not implemented. I will check next time, when I catch the crash. (it appears randomly)

Answer 3 · 2022-09-21T00:18:05.000Z

Thanks for the report. I'm able to reproduce it.

I think it's because didCreateTask, unlike all other delegate methods, is called synchronously on the callers thread, and not on the session's delegate queue.

Answer 4 · 2022-09-21T01:14:43.000Z

Fixed in 2.1.1

Answer 5 · 2022-09-22T10:06:00.000Z

Thanks for the fix. Unfortunately CreateAPI didn't move yet to v2. Would it be possible to backport the fix?

Answer 6 · 2022-09-22T12:32:48.000Z

Yes, I created two patches, including 1.0.4 for 1.x.