keflavich/cube-line-extractor

Clean-up Testing Calculations of Line Width, FWHM, Variance, and Centroid

jmangum opened this issue · 5 comments

Remnant from original development of this application. We calculate width_map, fwhm_map, sqrtmom2_map, and centroid_map but only use width_map and centroid_map for various kinds of masking. Before removing the unused fwhm_map and sqrtmom2_map calculations, wondering which of these width-related images:

(1) width_map
(2) fwhm_map
(3) sqrtmom2_map

...is the right one to use for width masking?

they're all equivalent. sqrtmom2=width=fwhm/2.35

ok. Suggest removing fwhm_map and sqrtmom2_map then and sticking with using width_map for masking.

could you submit a PR doing that?

Yes. I am working from a branch at the moment that I thought would address several of these minor "cleanup" issues.

Resolved with PR #28