kkjdaniel/react-native-device-display

Support newest versions of React Native

joeyvandijk opened this issue · 4 comments

joeyvandijk commented

I've seen your last commit, but while using React Native 0.7.1 & 0..8.0.rc.2 are giving me errors installing your module. Could you alter your peerDepedencies less strict, while now I cannot use (without hassle) your module in the new updates of React Native. Could you update like react-native-icons has done for example:

"peerdependencies" : {
    "react-native": ">=0.6.0 <1.0.0"
}

Thanks!

kkjdaniel commented

I'll push out an update today, thanks! All done!

joeyvandijk commented

Thanks, but I found out that the 0.x.x.-rc.x releases where not compatible, so could you update it to

"peerdependencies" : {
    "react-native": ">=0.6.0-rc || >=0.7.0-rc || >=0.8.0-rc || >=0.9.0-rc"
}

check if you want at NPM Semver to see which releases are tackled (use react-native).

Thanks again for your quick response!

kkjdaniel commented

Good spot, all fixed now and published to NPM, thanks!

joeyvandijk commented

Great!! ;)
On Jul 21, 2015 6:49 PM, "Karl Daniel" notifications@github.com wrote:

Closed #6
#6.

—
Reply to this email directly or view it on GitHub
#6 (comment)
.