Delivery Format: set `kn-ingress-format` ce extension in receiver
Cali0707 opened this issue · 4 comments
Problem
To support dispatching events from the Kafka based eventing components with the correct format when a user sets the spec.delivery.format to ingress, we need to set a cloudevent extension of kn-ingress-format to specify which format was used. This should be set to structured if the input event was structured, and binary if the input event was in binary. However, since this event may have been forwarded from earlier ingress, we need to only set the kn-ingress-format extension if it is not already present on the event.
Persona:
Which persona is this feature for?
Exit Criteria
Unit tests verifying that:
- If the extension is not present it is set correctly for both structured and binary events
- If the extension is already present, it is not changed for both structured and binary events
Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1-2
Additional context (optional)
Add any other context about the feature request here.
- Parent issue: knative/eventing#8057
/help
@Cali0707:
This request has been marked as needing help from a contributor.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
/help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/triage accepted
Given changes to the design of the feature, this is no longer needed