konstantinvlasenko/PowerSlim

Wrong scenario name does not cause test failure

mikeplavsky opened this issue · 3 comments

Such test will show no errors

|scenario|execute|command|check|result|
|check|eval|@command|@Result|

-!|script|
|execute 1|10+10+10|check1|30|

I don't feel like this is really a bug, or at least not really related to scenarios.

Scenarios are handled by the FitNesse web server, substituted like a macro before the commands are sent to SLIM. SLIM never sees a scenario and has no knowledge of them. So when a scenario substitution doesn't occur, the command just looks like an invalid function call or command to slim. While PowerSlim doesn't handle this well today, with the Improved Error Handling pull request, this problem will be reported as an EXCEPTION:COMMAND_NOT_FOUND: exception.

This is the pull request: #52

Cool!

Sent from my iPhone

06.12.2013, â 13:22, "ALuckyGuy" <notifications@github.commailto:notifications@github.com> íàïèñàë(à):

I don't feel like this is really a bug, or at least not really related to scenarios.

Scenarios are handled by the FitNesse web server, substituted like a macro before the commands are sent to SLIM. SLIM never sees a scenario and has no knowledge of them. So when a scenario substitution doesn't occur, the command just looks like an invalid function call or command to slim. While PowerSlim doesn't handle this well today, with the Improved Error Handling pull request, this problem will be reported as an EXCEPTION:COMMAND_NOT_FOUND: exception.

This is the pull request: #52#52


Reply to this email directly or view it on GitHubhttps://github.com//issues/56#issuecomment-30016620.

BTW: We have test which has this issue https://github.com/konstantinvlasenko/PowerSlim/blob/master/FitNesseRoot/PowerSlim/OriginalMode/SuiteCommon/SillyErrors/EvilEval/content.txt

First table
|evel|$a = 10|please use eval|

So we need to rise an EXCEPTION:COMMAND_NOT_FOUND (like ALuckyGuy mentioned), instead of just returning please use eval