korfuri/WhatTheRack

Randomness not so random.

NoxyNixie opened this issue · 5 comments

NoxyNixie commented

I love the idea of loosing some control while choosing your modules ... however I don't want to fill my rack with bunches of modules each time so I'm mostly interested in the "What The Mod" module.

Unfortunately after testing for just a very short period I found out that it is not random at all.

The following steps will show exactly what I mean:

  • Start new instance of VCV Rack
  • Add "What The Mod"
  • Click 5 times on "VCO"
  • Note the modules you get and in what order.
  • Reset your rack and relaunch VCV Rack
  • Add "What The Mod"
  • Click 5 times on "VCO"
  • Notice exactly the same modules in the same order.

It seems that the lists are randomized the same way each time instead of being seeded with a more random seed like the current time.

korfuri commented
NoxyNixie commented

Windows 7.

I know on some systems the random pool is not randomly seeded by default and looking at your code I didn't quickly see any seeding happening which would suggest it would use some form of deterministic randomization which does explain why the same modules pop up each time.

NoxyNixie commented

Thanks for the fix. When I wanted to try this out I went to your releases page here on github and downloaded the WhatTheRack-0.6.2-win.zip file. This build (or at least what is in that zip) seems to not fix the issue.

However I do notice the 0.6.2 in that filename and now suspect the build process uploaded the wrong files perhaps?

korfuri commented
NoxyNixie commented

Yep looks like its random now. Thanks a bunch ;)