Please add support for ~/.slime-secret

Question

Please add support for ~/.slime-secret

Closed this issue 4 years ago · 5 comments

Just come back to slimv after some years as vlime user and at first it didn't work for me.
The spawned lisp (sbcl 2.0.6) showed:

debugger invoked on a SIMPLE-ERROR in thread
#<THREAD "Swank 4005" RUNNING {10047F8903}>:
  Incoming connection doesn't know the password.

I could not find a reference to ~/.slime-secret in the documentation, nor in slimv's source. At the moment, I have to remove ~/.slime-secret in order to be able to use slimv.

Answer 1 · 2020-09-13T12:36:54.000Z

Added support for ~/.slime-secret in commits 5345aa9 and b3da3d1

Answer 2 · 2020-09-13T16:21:57.000Z

Sorry, I didn't realize you filed a pull request. Anyway, I disabled logging of the password in commit 3c0ea5e

Answer 3 · 2020-09-13T16:34:16.000Z

Thank you, it now works for the general case.
Anyway it still doesn't work for the corner case where ~/.slime-secret is empty (rm -f ~/.slime-secret; touch ~/.slime-secret).
Yeah, I know it's a lame password, so I guess you could ignore it.

Answer 4 · 2020-09-13T16:59:56.000Z

You are absolutely right, thanks for the feedback. I fixed the empty .slime-secret file case in commit a0452f2

Answer 5 · 2020-09-16T07:43:18.000Z

Thank you, closing as fixed.