M44d.TransformPosProj

Question

Closed this issue 2 years ago · 7 comments

It might be convenient also translate M44d.TransformPosProj to an appropriate shader code (like we already do with TransformDir and other).

let p = uniform.ProjTrafo.TransformPosProj someVec3

Answer 1 · 2022-11-08T17:31:39.000Z

Isn't the implementation in your commit wrong? Or did i miss the w-division?

Answer 2 · 2022-11-08T17:33:42.000Z

Should be there. Maybe you looked at the -Full variant in Compiler.fs? TransformPosProj is implemented at expression level in Shader.fs.

Answer 3 · 2022-11-08T17:48:10.000Z

But the full variant should also divide by w right?

Answer 4 · 2022-11-08T17:51:23.000Z

The Aardvark.Base implementation does not do the division.

Answer 5 · 2022-11-08T18:00:27.000Z

Okay, didn't know that, but TransformPosProjFull is then identical to m * V4d(arg, 1.0) right?

Answer 6 · 2022-11-08T18:01:47.000Z

Yeah, it's identical.

Answer 7 · 2022-11-08T18:02:55.000Z

I also find the name misleading, it should only be TransformPosFull.