Breaks check_mk-mysql.innodb_io
moschlar opened this issue · 7 comments
| Crash Type | check |
|---|---|
| Time | 2019-08-27 15:18:42 |
| Operating System | stretch |
| Check_MK Version | 1.5.0p21 |
| Edition | cre |
| Core | nagios |
| Python Version | 2.7.16 (default, Jul 30 2019, 14:46:21) [GCC 8.2.0] |
| Exception | NameError (global name 'check_diskstat_line' is not defined) |
| Traceback | File "/omd/sites/zdv/lib/python/cmk_base/checking.py", line 340, in execute_check raw_result = check_function(item, determine_check_params(params), section_content) File "/omd/sites/zdv/share/check_mk/checks/mysql", line 192, in check_mysql_iostat return check_diskstat_line(time.time(), 'innodb_io'+item, params, line) |
| Local Variables | {'item': u'mysql', 'line': [None, None, 150388649, 435139172], 'params': {}, 'parsed': {'mysql': {u'Aborted_clients': 0, .... |
| Python Module Paths | /omd/sites/zdv/local/lib/python/omd/sites/zdv/lib/python27.zip/omd/sites/zdv/lib/python2.7/omd/sites/zdv/lib/python2.7/plat-linux2/omd/sites/zdv/lib/python2.7/lib-tk/omd/sites/zdv/lib/python2.7/lib-old/omd/sites/zdv/lib/python2.7/lib-dynload/omd/sites/zdv/lib/python2.7/site-packages/omd/sites/zdv/lib/python |
| Host | wp-db-01 |
|---|---|
| Is Cluster Host | No |
| Check Type | mysql.innodb_io |
| Manual Check | No |
| Uses SNMP | No |
| Inline-SNMP | No |
| Check Item | mysql |
| Description | MySQL InnoDB IO mysql |
| Parameters | {} |
Probably has something to do with double inheritance (mysql.galera_cluster includes mysql, which includes diskstat.include from where this missing symbol should come)...
I'll investigate.
Thanks @moschlar for contributing - the fix is included in Release 1.1
Cool, thanks!
One thing though: Is there a specific reason why you don't upload the MKP at the Checkmk Exchange (https://checkmk.com/check_mk-exchange.php?exchange_search=galera&sort_by=)?
It's not that I didn't tried. The mkp was somehow not accepted and I don't receive any notification what was the reason for - might related to your fix.
I've submitted the new version yesterday - let's see "wait" for the result.
@moschlar - the mkp was accepted now and is available https://checkmk.com/check_mk-exchange.php?exchange_search=galera&sort_by=
Cool!