Circular dependencies in LESS imports cause AssetFactory::getLastModified() to enter an infinite loop

Question

Circular dependencies in LESS imports cause AssetFactory::getLastModified() to enter an infinite loop

LukeTowers opened this issue 7 years ago · 4 comments

AssetFactory->getLastModified() does not take into account circular dependencies when attempting to get the lastModified time for the provided asset using dependency resolving. If loopstart.less imports loopstep.less and loopstep.less includes loopstart.less; then it will result in an infinite loop when trying to get the last modified time for the tree as a whole.

loopstart.less

@import "loopstep.less";

loopstep.less

@import "loopstart.less";

Answer 1 · 2018-07-06T16:15:58.000Z

@dunets I'm glad I was able to provide some amusement for you 😝 😄

Answer 2 · 2020-02-05T18:51:42.000Z

@jaxwilko this is the issue I was talking about. Could you see if it still happens with the wikimedia package we're using instead?

Answer 3 · 2020-10-11T07:22:02.000Z

@jaxwilko did you ever get a chance to see if this is still present in wikimedia?

Answer 4 · 2020-10-11T11:08:16.000Z

@LukeTowers I think I had a look but I can't remember what the outcome was