kubernetes-sigs/aws-fsx-csi-driver

Adopt Kubernetes recommended label for `app`

thetric opened this issue · 4 comments

thetric commented

/kind bug

What happened?
The Helm chart is deployed with the resources labelled with app instead of the Kubernetes recommended label app.kubernetes.io/name.

What you expected to happen?

The Helm chart makes use of the recommended label.

How to reproduce it (as minimally and precisely as possible)?

Deploy it.

Anything else we need to know?:

This may possibly be a breaking change as it might require a re-installation of the Helm chart because the selector matchLabels will change.

Same issue in the External snapshotter driver: kubernetes-csi/external-snapshotter#843

Environment

  • Kubernetes version (use kubectl version): 1.27
  • Driver version: 0.10.0

Please also attach debug logs to help us better diagnose

n/a

jacobwolfaws commented

Hi @thetric thanks for opening this issue, I see that you linked the external-snapshotter and not the ebs-csi-driver, are you planning on opening a separate issue with the ebs driver?

This may possibly be a breaking change as it might require a re-installation of the Helm chart because the selector matchLabels will change.

This is important to note— we'll need to make sure to document this possibility once this change is made. If all the aws csi drivers need to make this change it should probably be a coordinated update.

thetric commented

I see that you linked the external-snapshotter and not the ebs-csi-driver, are you planning on opening a separate issue with the ebs driver?

Nice catch, I have corrected the issue description and opened an issue in the ebs driver repo.

On a first glance this looks like almost all Helm charts in this GitHub project are affected. I'm not quite sure how to communicate this without creating dozens of issues and separate discussions?

k8s-triage-robot commented

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

jacobwolfaws commented

Closing for the same reasons described here: kubernetes-sigs/aws-ebs-csi-driver#1653 (comment)